? ? Pending

User tests: Successful: Unsuccessful:

avatar hans2103
hans2103
1 Jul 2020

Pull Request for Issue # .

Summary of Changes

Landmarks provide a powerful way to identify the organization and structure of a web page.
This PR will wrap the output of the primary content of the page into a <main></main> element.

Main Landmark

A main landmark identifies the primary content of the page.

ARIA 1.1 Specification: main landmark

Design Patterns
  • Each page should have one main landmark.
  • The main landmark should be a top-level landmark.
  • When a page contains nested document and/or application roles (e.g. typically through the use of iframe and frame elements), each document or application role may have one main landmark.
  • If a page includes more than one main landmark, each should have a unique label.

You can use both <div role="main"> as HTML main element to define a main landmark.
I prefer the HTML main element.

This PR will not change the current look and feel of the Cassiopeia template.

Testing Instructions

Since landmarks are not directly visible for the sighted people you have to use some assistive technology to make it visible. You can use a browser extension to display landmarks:

Actual result BEFORE applying this Pull Request

The Landmark main is not present on the website. Screenshot below display the result of the Landmark extension for the Cassiopeia homepage with sample data
Schermafdruk 2020-07-01 11 54 40

Expected result AFTER applying this Pull Request

The Landmark main is present on the website. Screenshot below display the result of the Landmark extension for the Cassiopeia homepage with sample data.

Schermafdruk 2020-07-01 11 54 27

Documentation Changes Required

No changes required

avatar hans2103 hans2103 - open - 1 Jul 2020
avatar hans2103 hans2103 - change - 1 Jul 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jul 2020
Category Front End Templates (site)
avatar brianteeman
brianteeman - comment - 1 Jul 2020

There are many ways to skin a cat but this certainly works

avatar brianteeman brianteeman - test_item - 1 Jul 2020 - Tested successfully
avatar brianteeman
brianteeman - comment - 1 Jul 2020

I have tested this item successfully on 6b6c165


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29870.

avatar hans2103 hans2103 - change - 1 Jul 2020
The description was changed
avatar hans2103 hans2103 - edited - 1 Jul 2020
avatar ceford ceford - test_item - 1 Jul 2020 - Tested successfully
avatar ceford
ceford - comment - 1 Jul 2020

I have tested this item successfully on 6b6c165

For English speakers: Firefox => https://addons.mozilla.org/en/firefox/addon/landmarks/


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29870.

avatar richard67 richard67 - change - 1 Jul 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 1 Jul 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29870.

avatar richard67 richard67 - change - 1 Jul 2020
Labels Added: ? ?
avatar hans2103 hans2103 - change - 20 Jul 2020
Labels
avatar Quy Quy - change - 20 Jul 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-07-20 19:57:34
Closed_By Quy
avatar Quy Quy - close - 20 Jul 2020
avatar Quy Quy - merge - 20 Jul 2020

Add a Comment

Login with GitHub to post a comment