[#29863] - [4.0] Fix admin login button hover
- Fixed in Code Base
- 4 Jul 2020
- Medium
- Build: 4.0-dev
- # 29863
- Diff
- infograf768:4.0_admin_login_hover
User tests: Successful: Unsuccessful:
Summary of Changes
The admin login button has no background hover color.
This PR adds it. Same colors as btn-primary hover
Testing Instructions
Patch, run npm. Display admin login page.
Actual result BEFORE applying this Pull Request
Hovering the button does not change the background color.
Expected result AFTER applying this Pull Request
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
This was done intentionally. Don't ask me why.
Would still be nice to know why and maybe even chose another hover color if judged necessary before I change.
@coolcat-creations
Although your original patch has been modified since, is there any reason for a61df95#diff-64b20c259f11827e2b305938cad4b2a4
If not I will just kill totally #btn-login-submit in the scss and let btn-primary take over, as rightfully suggested by @SharkyKZ
| Labels |
Added:
NPM Resource Changed
?
|
||
Looks fine to me.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29863.
@coolcat-creations
Please test also and mark your test.
I have tested this item
Thank you, tested and works like described.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29863.
| Status | Pending | ⇒ | Ready to Commit |
rtc. Tks for testing
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29863.
Quy
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-04 20:11:57 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
This was done intentionally. Don't ask me why. If you want to make the change anyways, just remove code for
#btn-login-submitcompletely.