Joomla! Issue Tracker | Joomla! CMS #29860 - [4] Use modal.js instead of batch.js in editor when inserting article link

? ?

Fixed in Code Base
2 Jul 2020
Medium
Build: 4.0-dev
# 29860
ReLater:patch-1

ReLater
30 Jun 2020

Fixes #29858

Summary of Changes

Replaced wrong asset com_content.admin-articles-batch with com_content.admin-articles-modal

Testing Instructions

See issue #29858

Actual result BEFORE applying this Pull Request

No insertion of article anchor in editor text.

Expected result AFTER applying this Pull Request

Known behavior is back.

f297cb4 30 Jun 2020

Use modal.js instead of batch.js

ReLater - open - 30 Jun 2020

brianteeman - comment - 1 Jul 2020

It would be useful to know which PR broke the behaviour so that we can be certain that the reason for that PR is still resolved after this change

richard67 - comment - 1 Jul 2020

@brianteeman It was this commit 4d8983f#diff-a42b2b0c3999aaf0517b60ea5d19f8cc from this PR #29464.

As the screenshot shows, the script was com_content/admin-articles-modal.min.js before the change to web asset manager, and it was then changed to $wa->...->useScript('com_content.admin-articles-batch').

So I would say this PR here is correct.

brianteeman - comment - 1 Jul 2020

Always good to identify where the problem came from, especially when it is a recent bug ;)

ReLater - comment - 1 Jul 2020

Always good to identify where the problem came from, especially when it is a recent bug

I've checked it before I posted this pr and checked also other changes of that pr. The error is too obvious to waste time with additional descriptions. Anybody can use the History feature on GitHub.