Feeling Lucky
NPM Resource Changed
?
[#29856] - [4.0] Fix missing $ for scss variable cassiopeia-grid-gutter
- Fixed in Code Base
- 30 Jun 2020
- Medium
- Build: 4.0-dev
- # 29856
- Diff
- hans2103:origin/feature/scss-fix-cassiopeia-grid-gutter
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR just adds a missing $ to a scss variable
Testing Instructions
npm run build:cssto compile the css- check the css output
- apply PR
npm run build:cssto compile the css- check the css output and compare
Actual result BEFORE applying this Pull Request
.site-grid .container-component > div + div,
.site-grid .container-sidebar-left > div + div,
.site-grid .container-sidebar-right > div + div {
margin-top: cassiopeia-grid-gutter;
}
Expected result AFTER applying this Pull Request
.site-grid .container-component > div + div,
.site-grid .container-sidebar-left > div + div,
.site-grid .container-sidebar-right > div + div {
margin-top: 15px;
}
Documentation Changes Required
No changes required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) NPM Change |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-30 15:30:40 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
NPM Resource Changed
?
|
||
wilsonge
- comment
- 30 Jun 2020
Merged with the good test and on review
I have tested this item✅ successfully on 1885f24
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29856.