[#29833] - [4.0] Fix "Exit Recovery Mode" link
- Fixed in Code Base
- 5 Jul 2020
- Medium
- Build: 4.0-dev
- # 29833
- Diff
- SharkyKZ:j4/fix/menu-recovery
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Fixes #29829.
Summary of Changes
Makes "Exit Recovery Mode" link clickable.
Testing Instructions
Menus -> Manager -> Select Administrator -> Click New =>
Title = MyBrokenMenu
Unique Name = MyBrokenMenu
Import a preset = none
Click Save and close
Click "Add a module for this menu"
Select MyBrokenMenu under Administrator in the left menu
Title = MyBrokenMenuModule
Menu to show = MyBrokenMenu
CheckMenu = yes
Position = Menu [menu]
Click save & closeEnable Menu Recovery Mode
Actual result BEFORE applying this Pull Request
No href on the a tag for Exit Recovery mode and is unclickable.
Expected result AFTER applying this Pull Request
Exit Recovery mode is a hyperlink that is clickable in the menu
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
I have tested this item
obvious error in the field name - thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29833.
I have tested this item
Tested successfully in Beta3-dev of 5 July.
Environment Windows 10 Wampserver 3.2.2 Apache 2.4.43 MySQL 8.0.20 PHP 7.4.7
Had to change Error Reporting to 'Simple' because of numerous notices but exit from the Recovery Mode worked all right:
Notice: Undefined property: Joomla\CMS\Menu\AdministratorMenuItem::$element in C:\www\joomla4\administrator\modules\mod_menu\src\Menu\CssMenu.php on line 313
Notice: Undefined property: Joomla\CMS\Menu\AdministratorMenuItem::$element in C:\www\joomla4\administrator\modules\mod_menu\src\Menu\CssMenu.php on line 327
Notice: Undefined property: Joomla\CMS\Menu\AdministratorMenuItem::$class in C:\www\joomla4\administrator\modules\mod_menu\src\Menu\CssMenu.php on line 513
Notice: Undefined property: Joomla\CMS\Menu\AdministratorMenuItem::$ajaxbadge in C:\www\joomla4\administrator\modules\mod_menu\tmpl\default_submenu.php on line 99
Notice: Undefined property: Joomla\CMS\Menu\AdministratorMenuItem::$dashboard in C:\www\joomla4\administrator\modules\mod_menu\tmpl\default_submenu.php on line 173
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29833.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29833.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-05 13:41:36 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
Merged thanks
I have tested this item? unsuccessfully on e8ab80d
Are the instructions correct? On first pass without patch I got as far as Click "Add a module for this menu". That brough up a modal box so Select MyBrokenMenu under Administrator in the left menu did not make sense. Carrying on to Save and Close, after close there was a warning message with a link to Enable Menu Recovery Mode. After that - where is Enable Menu Recovery Mode. Start again - never saw that first warning message again. Where is Exit Recovery Mode? Applied patch - same - no sign of Exit Recovery Mode link. I don't see anything in the menus.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29833.