? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
28 Jun 2020

Summary of Changes

Standardise all indents correctly - no functionality changes at all.

Testing Instructions

Nothing to test

Actual result BEFORE applying this Pull Request

Some instructions within modules were not indented, some were, some with space, some with tab

Expected result AFTER applying this Pull Request

nicely laid out file

Documentation Changes Required

None

avatar PhilETaylor PhilETaylor - open - 28 Jun 2020
avatar PhilETaylor PhilETaylor - change - 28 Jun 2020
Status New Pending
avatar jwaisner jwaisner - change - 29 Jun 2020
Priority Medium Very low
avatar ceford
ceford - comment - 29 Jun 2020

This looks a bit odd in comparison to other indents. Before:

#<IfModule mod_headers.c>
#Header always set Cross-Origin-Resource-Policy "same-origin"
#Header always set Cross-Origin-Embedder-Policy "require-corp"
#</IfModule>

After:

#<IfModule mod_headers.c>
#   Header always set Cross-Origin-Resource-Policy "same-origin"
#   Header always set Cross-Origin-Embedder-Policy "require-corp"
#</IfModule>

The other indents are before the #. Otherwise it is fine.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29823.

avatar PhilETaylor
PhilETaylor - comment - 29 Jun 2020

It looks funny, until you Uncomment the lines to make them active and then they look perfect in the .htaccess without you having to indent them

avatar PhilETaylor PhilETaylor - change - 29 Jun 2020
Labels Added: ?
avatar PhilETaylor
PhilETaylor - comment - 29 Jun 2020

Converted spaces to tabs

avatar toivo toivo - test_item - 5 Jul 2020 - Tested successfully
avatar toivo
toivo - comment - 5 Jul 2020

I have tested this item successfully on 8dd2777

Tested successfully in Beta3-dev of 5 July.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29823.

avatar Quy Quy - test_item - 7 Jul 2020 - Tested successfully
avatar Quy
Quy - comment - 7 Jul 2020

I have tested this item successfully on 8dd2777


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29823.

avatar Quy Quy - change - 7 Jul 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 7 Jul 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29823.

avatar richard67
richard67 - comment - 11 Jul 2020

@PhilETaylor Any reason why this is not done on staging and later merged up? Now as it is for 4.0-dev only, a comparison between the J4 and the J3 file will show differences. Not sure if that is good or bad, but I personally won't like it.

avatar PhilETaylor
PhilETaylor - comment - 11 Jul 2020

Well for a start most of these lines only exist in 4.0 :-)

avatar richard67
richard67 - comment - 11 Jul 2020

Yes, I just see.

avatar richard67 richard67 - change - 11 Jul 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-07-11 14:45:44
Closed_By richard67
Labels Added: ?
avatar richard67 richard67 - close - 11 Jul 2020
avatar richard67 richard67 - merge - 11 Jul 2020
avatar richard67
richard67 - comment - 11 Jul 2020

Thanks!

Add a Comment

Login with GitHub to post a comment