[#29819] - [4.0][CLI] No confirmation step on deleting users
- Closed
- 20 Jul 2020
- Medium
- Build: staging
- # 29819
Steps to reproduce the issue
Expected result
a Are you sure you want to delete this user?
Actual result
User deleted without confirmation
Additional comments
The CLI asked for confirmation when deleting an extension - but not when deleting a user
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-29 06:44:50 |
| Closed_By | ⇒ | alikon |
| Status | Closed | ⇒ | New |
| Closed_Date | 2020-06-29 06:44:50 | ⇒ | |
| Closed_By | alikon | ⇒ |
#29827 was correct but it should use $io->confirm() instead of $io->ask(). The confirm() helper very specifically is only going to accept a yes looking answer as confirmed, the way you handled it it will basically accept anything that is not "no" as a "yes" looking answer.
But, you also need to check Symfony's API to see what happens if it determines the current console session is non-interactive. It may very well be that it skips the prompt if it determines the session is non-interactive.
(BTW, a --force flag should also be introduced into these things that bypasses the prompt)
jwaisner
- | Status | New | ⇒ | Confirmed |
| Status | Confirmed | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-20 17:16:31 |
| Closed_By | ⇒ | alikon |
please test #29827