? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
28 Jun 2020

Updates the strings displayed when running php cli/joomla.php list to ensure consistent grammar and tense etc

(a subsequent pr will be created for php cli/joomla.php help)

avatar brianteeman brianteeman - open - 28 Jun 2020
avatar brianteeman brianteeman - change - 28 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jun 2020
Category Libraries
avatar Quy Quy - test_item - 28 Jun 2020 - Tested successfully
avatar Quy
Quy - comment - 28 Jun 2020

I have tested this item successfully on 6744518


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29799.

avatar richard67
richard67 - comment - 28 Jun 2020

@brianteeman Shouldn't this one be changed, too?

https://github.com/brianteeman/joomla-cms/blob/cli/libraries/src/Console/ChangeUserPasswordCommand.php#L167

Changes a user's password -> Change a user's password

avatar brianteeman brianteeman - change - 28 Jun 2020
Labels Added: ?
avatar richard67 richard67 - test_item - 28 Jun 2020 - Tested successfully
avatar richard67
richard67 - comment - 28 Jun 2020

I have tested this item successfully on 1ecc4dd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29799.

avatar richard67
richard67 - comment - 28 Jun 2020

@Quy Could you test again (or short review should be sufficient, too)?

avatar jwaisner jwaisner - test_item - 28 Jun 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 28 Jun 2020

I have tested this item successfully on 1ecc4dd

String changes look good.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29799.

avatar jwaisner
jwaisner - comment - 28 Jun 2020

I have tested this item successfully on 1ecc4dd

String changes look good.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29799.

avatar jwaisner jwaisner - change - 28 Jun 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 28 Jun 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29799.

avatar Quy Quy - change - 28 Jun 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-06-28 17:25:05
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 28 Jun 2020
avatar Quy Quy - merge - 28 Jun 2020
avatar brianteeman
brianteeman - comment - 28 Jun 2020

thanks - now i can work on the help

Add a Comment

Login with GitHub to post a comment