[#29790] - [4.0] Fix save2copy for workflows
- Fixed in Code Base
- 28 Jun 2020
- Medium
- Build: 4.0-dev
- # 29790
- Diff
- chmst:fix-workflow-save2copy
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #29597 .
Summary of Changes
Remove rquired from field default
Testing Instructions
see #29597
Actual result BEFORE applying this Pull Request
Error: Field required: default
Expected result AFTER applying this Pull Request
No Warning, the workflow is saved as copy
Documentation Changes Required
no
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_workflow |
I have tested this item
Change fixes various issues outlined in #29597
- Second Save after changing workflow to default no longer has error.
- Save and Close on a default workflow saves and closes the workflow
A related issue:
- #29597 was raised after testing the special Workflow Beta 2 Dev assembled for testing Workflow just before the 4.0.0-beta1 was released.
- It appears that between the Beta 2 Dev and 4.0.0-beta1, the "Save as Copy" functionality for Workflows was disabled, so this also needs to be patched.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29790.
Save as Copy was fixed in #29263
I updated 4.0.0-beta1 to latest nightly build of 4.0-dev which has that included, and so Save as Copy toolbar item is then applied.
This pull request then additionally fixes the issue and a copy can be saved.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29790.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29790.
Thanks! Have tested it with sucess, too, before merging. Also the "home" field ("Default page") for menu items has no "required" attribute, so this here is consistent with that.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-28 17:13:06 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
?
|
||
I have tested this item✅ successfully on 5bf6fd5
Result with Patch: Message Item Saved.
But is this correct?
COM_WORKFLOW_BASIC_WORKFLOW (2)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29790.
Edit: Ah, I see, I can change the title :-)