? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
25 Jun 2020

Fixes #29549

Summary of Changes

Fix filters width.

Thanks @PixedBo for the code.

Testing Instructions

Apply PR
Run npm i

Go to Private Messages
Click Filter Options

Actual result BEFORE applying this Pull Request

Wide dropdown

Expected result AFTER applying this Pull Request

Normal width dropdown

avatar Quy Quy - open - 25 Jun 2020
avatar Quy Quy - change - 25 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jun 2020
Category Administration Templates (admin) NPM Change
avatar infograf768 infograf768 - test_item - 25 Jun 2020 - Tested successfully
avatar infograf768
infograf768 - comment - 25 Jun 2020

I have tested this item successfully on 7f2c31f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29777.

avatar PixedBo
PixedBo - comment - 25 Jun 2020

Tested and seems ok.
Please test also other pages with filters as this fix is for the whole filter system visualization

avatar infograf768
infograf768 - comment - 25 Jun 2020

Seems OK or works fine? I evidently have also tested other occurrences. Have you not?
To understand this PR look at https://css-tricks.com/auto-sizing-columns-css-grid-auto-fill-vs-auto-fit/

avatar PixedBo
PixedBo - comment - 25 Jun 2020

Sorry, i was meaning "works fine". I've tested with windows browsers and mobile and found no problems. Can't test with linux, macOS or iOS as i don't have one. Thanks for the link, i know the difference as i've suggested the fix here #29549

avatar infograf768
infograf768 - comment - 25 Jun 2020
avatar PixedBo PixedBo - test_item - 25 Jun 2020 - Tested successfully
avatar PixedBo
PixedBo - comment - 25 Jun 2020

I have tested this item successfully on 7f2c31f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29777.

avatar infograf768 infograf768 - change - 25 Jun 2020
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 25 Jun 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29777.

avatar infograf768 infograf768 - change - 25 Jun 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-06-25 08:06:05
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 25 Jun 2020
avatar infograf768 infograf768 - merge - 25 Jun 2020
avatar infograf768
infograf768 - comment - 25 Jun 2020

Tks both

Add a Comment

Login with GitHub to post a comment