Feeling Lucky
?
[#29773] - [4.0] Login bad error message
- Closed
- 14 Oct 2020
- Medium
- Build: Manana
- # 29773
Steps to reproduce the issue
Upgrade nightly build (today is 2020-06-24). Logout / Login Administrator.
Expected result
Home Dashboard / Control Panel OK
Actual result
There is a stray error message as illustrated:
The blue link leads to Urgent privacy requests - the ones I forgot about whilst testing.
System information (as much as possible)
Additional comments
The last thing I did was save Global Configuration after changing default Captcha.
joomla-cms-bot
- 
ReLater
- comment
- 27 Jun 2020
It looks like the alert message has been removed by @brianteeman on purpose: See #24893
but then the JS logic was brought back some months later by @bembelimen erroneously: See #25570
and 50eae65#diff-e815986c9bc783495edecba9f87d8f84 ( @fancyFranci )
Otherwise we both wouldn't see the alert message concerning privacy requests.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-14 14:20:27 |
| Closed_By | ⇒ | ceford |
ceford
- comment
- 14 Oct 2020
I think this problem has gone away
See next comment #29773 (comment)
The first part is easy. The lines"REQUESTFOUND_MESSAGE" => Text::_('PLG_QUICKICON_PRIVACYCHECK_REQUESTFOUND_MESSAGE'),"REQUESTFOUND_BUTTON" => Text::_('PLG_QUICKICON_PRIVACYCHECK_REQUESTFOUND_BUTTON'),are missing here:
https://github.com/joomla/joomla-cms/blob/4.0-dev/plugins/quickicon/privacycheck/privacycheck.php#L63-L65
Then I get:
PLG_QUICKICON_PRIVACYCHECK_REQUESTFOUND_MESSAGE="%s Urgent Privacy Request(s) to manage."to
PLG_QUICKICON_PRIVACYCHECK_REQUESTFOUND_MESSAGE="urgent Privacy Request(s) to manage."It's used here(?) .
https://github.com/joomla/joomla-cms/blob/4.0-dev/build/media_source/plg_quickicon_privacycheck/js/privacycheck.es6.js#L46
I don't know if JS has a sprintf analog and if it should be used here if yes.