? ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
23 Jun 2020

Pull Request for Issue #29748

Summary of Changes

Allow translation of Content Security Policy in the fieldset label as this is not the code part but the concept itself.
Comment added is
; Please do not translate (CSP) in the following language string as this shorthand is common to all languages.

Testing Instructions

Enable debug lang
Load csp administrator/index.php?option=com_config&view=component&component=com_csp

Actual result BEFORE applying this Pull Request

Screenshot 2020-06-21 at 21 05 03

Expected result AFTER applying this Pull Request

Screen Shot 2020-06-23 at 09 19 33

avatar infograf768 infograf768 - open - 23 Jun 2020
avatar infograf768 infograf768 - change - 23 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jun 2020
Category Administration com_csp Language & Strings
avatar ChristineWk ChristineWk - test_item - 23 Jun 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 23 Jun 2020

I have tested this item successfully on 5f0a1d3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29768.

avatar PhilETaylor
PhilETaylor - comment - 23 Jun 2020

fancy doing this one at the same time please?

85318997-d47a7a00-b4b8-11ea-8835-87a2c034b28a

avatar infograf768
infograf768 - comment - 23 Jun 2020

Afaik that one is not translatable. We can change the fieldset label to take off hyphens but I would not create a lang string. Have also to check rtl.

avatar alikon alikon - test_item - 23 Jun 2020 - Tested successfully
avatar alikon
alikon - comment - 23 Jun 2020

I have tested this item successfully on 5f0a1d3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29768.

avatar alikon alikon - change - 23 Jun 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 23 Jun 2020

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29768.

avatar infograf768 infograf768 - change - 24 Jun 2020
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jun 2020
Category Administration com_csp Language & Strings Administration com_csp Language & Strings Front End Plugins
avatar infograf768
infograf768 - comment - 24 Jun 2020

@zero-24

When i'm requested to leave my comments here it is but this is just my personal opinion. Up to the merging maintainer to take the final decision. In my opinion this is a technical term and we should not suggest the translators to translate it.

I understand your comment.

The solution is to NEVER use the term without hyphens, which means that it also has to be modified in each string and comment should be added to NEVER translate it.

For example:
COM_CSP_AUTO_UNSAFE_EVAL_WARNING="You have configured a rule that still allows 'unsafe-eval' that bypasses the Content Security Policy and allows the execution of code injected into DOM APIs such as eval()."
should be
COM_CSP_AUTO_UNSAFE_EVAL_WARNING="You have configured a rule that still allows 'unsafe-eval' that bypasses the Content-Security-Policy and allows the execution of code injected into DOM APIs such as eval()."

COM_CSP_CONTENTSECURITYPOLICY="<a href='https://scotthelme.co.uk/content-security-policy-an-introduction' target='_blank' rel='noopener noreferrer'>Content Security Policy (CSP)</a>"
to
COM_CSP_CONTENTSECURITYPOLICY="<a href='https://scotthelme.co.uk/content-security-policy-an-introduction' target='_blank' rel='noopener noreferrer'>Content-Security-Policy (CSP)</a>"

and
COM_CSP_FILTER_SEARCH_LABEL="Search Content Security Policy Reports"
to
COM_CSP_FILTER_SEARCH_LABEL="Search Content-Security-Policy Reports"

I am closing this now.

avatar infograf768 infograf768 - close - 24 Jun 2020
avatar infograf768 infograf768 - change - 24 Jun 2020
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2020-06-24 06:40:18
Closed_By infograf768
Labels Added: ?

Add a Comment

Login with GitHub to post a comment