? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
19 Jun 2020

PR for #29334

Adds the ability to specify sub folders that are not folders on the root as the places I want to store images

avatar brianteeman brianteeman - open - 19 Jun 2020
avatar brianteeman brianteeman - change - 19 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Jun 2020
Category Front End Plugins
avatar Quy
Quy - comment - 20 Jun 2020

It takes 20 seconds to load using WAMP on Windows 10.

avatar infograf768
infograf768 - comment - 20 Jun 2020

And for me, Firefox freezes after a few seconds.

First time I test this plugin. Imho it should prevent choosing any core folder in root except the images one. I.e. it would let choose a custom root folder + images

avatar infograf768
infograf768 - comment - 20 Jun 2020

So, it would be OK if we do

					<field
							name="directory"
							type="folderlist"
							default="images"
							label="PLG_FILESYSTEM_LOCAL_DIRECTORIES_DIRECTORY_LABEL"
							folderFilter=""
							exclude="administrator|api|build|components|cache|includes|installation|language|libraries|logs|media|modules|node_modules|plugins|templates|tests|tmp|bin|cli|layouts"
							stripext=""
							recursive="true"
						/>

In that case we would get with this PR
Screen Shot 2020-06-20 at 08 06 48

avatar brianteeman
brianteeman - comment - 20 Jun 2020

I am going to close this. It is clearly not practical to have the full recursive folder tree and the suggestion of @infograf768 doesn't work either as it removes the possibility of using media manager on other folders.

avatar brianteeman brianteeman - change - 20 Jun 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-06-20 07:32:52
Closed_By brianteeman
Labels Added: ?
avatar brianteeman brianteeman - close - 20 Jun 2020
avatar infograf768
infograf768 - comment - 20 Jun 2020

It does not make sense to display all core folders in this plugin, but it makes sense to use a custom image folder. So, even if we don't choose recursing, we still should limit the folders displayed in the dropdown to images and custom root folders.

avatar infograf768
infograf768 - comment - 20 Jun 2020

If no one makes a PR, I will.

avatar ceford
ceford - comment - 20 Jun 2020

Whilst looking at this, without applying the patch, I added templates to the Select Directories list. Worked as expected. Then I removed templates and Media displayed an internal error:

screen shot 2020-06-20 at 07 56 34

It went away after selecting the Local images folder.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29719.
avatar infograf768
infograf768 - comment - 20 Jun 2020

@ceford
This means that we do not check for the existence of folders before displaying them.
I think it can be solved, but it is a different issue.

EDIT, looks like we only use
throw new FileNotFoundException; and no message/error
or InvalidPathException which is empty

Add a Comment

Login with GitHub to post a comment