Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#29704] - [4.0] Fix WebAuthn white icons

? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
19 Jun 2020

Pull Request for Issue #29700

Summary of Changes

  • Replace the icon- prefix with fa-
  • Remove the icon-white class so that icons inherit the colour of the parent

Testing Instructions

Code review

avatar C-Lodder C-Lodder - open - 19 Jun 2020
avatar C-Lodder C-Lodder - change - 19 Jun 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Jun 2020
Category ⇒ Layout
avatar PhilETaylor
PhilETaylor - comment - 19 Jun 2020

This is not for #29701 it’s for #29700

avatar PhilETaylor
PhilETaylor - comment - 19 Jun 2020

This is not for #29701 it’s for #29700

avatar C-Lodder C-Lodder - change - 19 Jun 2020
The description was changed
avatar C-Lodder C-Lodder - edited - 19 Jun 2020
avatar C-Lodder
C-Lodder - comment - 19 Jun 2020

Thanks. Link updated

avatar ChristineWk ChristineWk - test_item - 19 Jun 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 19 Jun 2020

I have tested this item ✅ successfully on c0a5a19

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29704.

avatar wilsonge wilsonge - change - 19 Jun 2020
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-06-19 18:36:37
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 19 Jun 2020
avatar wilsonge wilsonge - merge - 19 Jun 2020
avatar wilsonge
wilsonge - comment - 19 Jun 2020

Thanks!

Add a Comment

Login with GitHub to post a comment