? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
18 Jun 2020

Summary of Changes

Removes import of Joomla\Plugin\System\Webauthn\PluginTraits\ButtonsInUserPage which doesn't exist.

Testing Instructions

Code review.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 18 Jun 2020
avatar SharkyKZ SharkyKZ - change - 18 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jun 2020
Category Unit Tests Repository Administration
avatar richard67
richard67 - comment - 18 Jun 2020

@SharkyKZ It seems Appveyor and Drone didn't get the base branch change. Maybe they will if you commit a change, dummy change or update to a change in 4.0-dev, if any, but maybe it's the easiest thing if you redo the PR. Or someone merges it by review.

avatar SharkyKZ SharkyKZ - change - 18 Jun 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jun 2020
Category Unit Tests Repository Administration Front End Plugins
avatar SharkyKZ
SharkyKZ - comment - 18 Jun 2020

Branch updated.

avatar richard67 richard67 - test_item - 18 Jun 2020 - Tested successfully
avatar richard67
richard67 - comment - 18 Jun 2020

I have tested this item successfully on a5147c6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29686.

avatar alikon alikon - test_item - 18 Jun 2020 - Tested successfully
avatar alikon
alikon - comment - 18 Jun 2020

I have tested this item successfully on a5147c6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29686.

avatar alikon alikon - change - 18 Jun 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 18 Jun 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29686.

avatar wilsonge wilsonge - change - 19 Jun 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-06-19 10:10:50
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 19 Jun 2020

Thanks!

Add a Comment

Login with GitHub to post a comment