[#29683] - Set error when using invalid IDs in history version comparison
- Fixed in Code Base
- 28 Jun 2020
- Medium
- Build: staging
- # 29683
- Diff
- SharkyKZ:j3/notice/version-compare
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Fixes #29678.
Summary of Changes
Fixes notices when using invalid IDs in history version comparison.
Testing Instructions
Go to faked admin url (change cb519da4124ac219494e83630c56cb09 to your session token):
http://127.0.0.1/administrator/index.php?option=com_contenthistory&view=compare&layout=compare&tmpl=component&cb519da4124ac219494e83630c56cb09=1&id1=&id2=
Expected result
No notices.
Actual result
Notices like these:
Notice: Undefined property: stdClass::$id in administrator\components\com_contenthistory\views\compare\tmpl\compare.php on line 63
Notice: Trying to get property 'value' of non-object in administrator\components\com_contenthistory\views\compare\tmpl\compare.php on line 63
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content com_contenthistory Language & Strings |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29683.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29683.
| Labels |
Added:
?
?
?
|
||
| Labels | |||
Adding back the test results because last change after tests was just language string reordering.
RTC also still valid.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29683.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-28 19:02:05 |
| Closed_By | ⇒ | zero-24 |
Merging
I have tested this item✅ successfully on f31bfa2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29683.