Feeling Lucky
NPM Resource Changed
?
?
[#29681] - [4.0] Media Manager modal toolbar
- Fixed in Code Base
- 18 Jun 2020
- Medium
- Build: 4.0-dev
- # 29681
- Diff
- brianteeman:16jun
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
scss has been changed in this pr so you will need to node build.js --compile-css
The problem
The toolbar buttons in the media manager modal eg when adding an intro image is displayed with the full colours and no spacing
The solution
This could be technically wrong. It works but maybe there is a better way. It wraps the toolbar with the subhead div and adds a noshadow class
before
after
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media Templates (admin) NPM Change |
C-Lodder
- comment
- 18 Jun 2020
I have tested this item
This'll do
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29681.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 18 Jun 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29681.
| Labels |
Added:
?
?
NPM Resource Changed
|
||
| Labels | |||
Quy
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-18 17:05:04 |
| Closed_By | ⇒ | Quy |
brianteeman
- comment
- 18 Jun 2020
thanks
I have tested this item✅ successfully on f635694
No idea if it is technically the best solution or not. Maybe @ciar4n can tell, or @C-Lodder ?
But it works well.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29681.