?
avatar PhilETaylor
PhilETaylor
16 Jun 2020

Steps to reproduce the issue

Joomla 4 beta 1
Create an article and create loads of versions by clicking save many times
Click versions button
Click on a date/time
Note New window popup

Expected result

New window displays details of the article

Actual result

New window displays an error message

Call to a member function load() on bool

Screenshot 2020-06-16 at 23 07 58

avatar PhilETaylor PhilETaylor - open - 16 Jun 2020
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jun 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 16 Jun 2020
avatar PhilETaylor
PhilETaylor - comment - 16 Jun 2020

can be replicated at made up url:

/administrator/index.php?option=com_contenthistory&view=preview&layout=preview&tmpl=component&version_id=

avatar SharkyKZ
SharkyKZ - comment - 17 Jun 2020

Can you test on git clone or latest nightly? #29326 might have fixed this.

avatar PhilETaylor
PhilETaylor - comment - 17 Jun 2020

tested on e375092 and the problem remains, only difference this morning is the left menu in the popup is collapsed on load

Screenshot 2020-06-17 at 09 57 21

avatar SharkyKZ
SharkyKZ - comment - 18 Jun 2020

I can't reproduce the issue. Can you enable debug and post the stack trace?

avatar PhilETaylor
PhilETaylor - comment - 18 Jun 2020

Today on 50ef84d

Installed Joomla from scratch with no crazy changes to setting, - no sample data

Logged into admin

Went straight to

http://127.0.0.1/administrator/index.php?option=com_contenthistory&view=preview&layout=preview&tmpl=component&version_id=

and replicated the error - enabled debug mode and error reporting = development and get:

Screenshot 2020-06-18 at 16 20 49

avatar PhilETaylor
PhilETaylor - comment - 18 Jun 2020

$typesTable is false...

public static function prepareData(ContentHistory $table)
	{
		$object = static::decodeFields($table->version_data);
		$typesTable = Table::getInstance('Contenttype', 'Joomla\\CMS\\Table\\');
		$typeAlias = explode('.', $table->item_id);
		array_pop($typeAlias);
		$typesTable->load(array('type_alias' => implode('.', $typeAlias)));
		$formValues = static::getFormValues($object, $typesTable);
		$object = static::mergeLabels($object, $formValues);
		$object = static::hideFields($object, $typesTable);
		$object = static::processLookupFields($object, $typesTable);

		return $object;
	}
avatar SharkyKZ SharkyKZ - change - 18 Jun 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-06-18 16:34:49
Closed_By SharkyKZ
avatar SharkyKZ
SharkyKZ - comment - 18 Jun 2020

Please test PR #29692.

avatar SharkyKZ SharkyKZ - close - 18 Jun 2020

Add a Comment

Login with GitHub to post a comment