? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
16 Jun 2020

Summary of Changes

Allow Super User groups to always show in the webservices plugin so that they can view their api tokens.

Testing Instructions

View API plugin. select some user groups. currently super user doesn't show. Save some other user groups to access the token. Before patch a super user loose their ability to view the API token. After patch they can still view the token.

Documentation Changes Required

None

avatar wilsonge wilsonge - open - 16 Jun 2020
avatar wilsonge wilsonge - change - 16 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jun 2020
Category Front End Plugins
avatar wilsonge
wilsonge - comment - 16 Jun 2020

@nikosdion tagging this so you can review

avatar uglyeoin uglyeoin - test_item - 16 Jun 2020 - Tested successfully
avatar uglyeoin
uglyeoin - comment - 16 Jun 2020

I have tested this item successfully on b7157e7

I have tested this patch. I see the "super user" group and selecting it the user can see the API key.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29649.
avatar uglyeoin uglyeoin - test_item - 16 Jun 2020 - Tested successfully
avatar Bodge-IT Bodge-IT - test_item - 16 Jun 2020 - Tested successfully
avatar Bodge-IT
Bodge-IT - comment - 16 Jun 2020

I have tested this item successfully on b7157e7

I tested this succesfully. Super Users now available for selection/de-selection


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29649.

avatar alexandreelise alexandreelise - test_item - 16 Jun 2020 - Tested successfully
avatar alexandreelise
alexandreelise - comment - 16 Jun 2020

I have tested this item successfully on b7157e7

I tested this successfully on my Linux laptop on Ubuntu 20.04 LTS with PHP 7.3.17 and a dockerized MySQL 5.7 instance and Joomla! 4.x beta 1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29649.

avatar nikosdion
nikosdion - comment - 17 Jun 2020

Looks good to me.

avatar SharkyKZ SharkyKZ - change - 17 Jun 2020
Status Pending Ready to Commit
Labels Added: ?
avatar SharkyKZ
SharkyKZ - comment - 17 Jun 2020

RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29649.

avatar wilsonge wilsonge - change - 17 Jun 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-06-17 10:21:12
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 17 Jun 2020
avatar wilsonge wilsonge - merge - 17 Jun 2020
avatar wilsonge
wilsonge - comment - 17 Jun 2020

Thanks guys!

Add a Comment

Login with GitHub to post a comment