User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
It should handle RTL.
Not sure about that. Example: using Open a New Tab in a browser always creates the tab to the right of the open one.
Plus, this is about going back and not opening a new tab.
OK
At least in chrome the new window opens to the left in both hebrew and arabic
Good to know.
LOL... this is just a replacement of a broken icon, not about adding rtl to an existing button that doesn't have rtl.
@Quy what you are referring to in the workflow component is NOT using the ToolbarHelper::back() but constructs the link that the page is routed back to. A lot of code that could have been implemented easier...
I have no idea about rtl so I also have no clue as to whether a back button in rtl should be 'back >' or 'back <' or '>back' or '< back' (the last one as it currently is in J3)
I am just replacing the < icon with the < icon making the assumption that < is the correct icon as that was always the case
I have tested this item
RTL can be fixed in a separate PR.
RTL can be fixed in a separate PR.
I can do it in this PR, but as said, then somebody should set the requirement as to the position / direction of the <, >
See my screenshot above for RTL pointing to the right. Thank you!
@Ruud68 For LTR/RTL handling you could do it like here:
$arrow = Factory::getLanguage()->isRtl() ? 'arrow-right' : 'arrow-left';
and then
$bar->appendButton('Link', $arrow, $alt, $href);
or maybe all in one:
$bar->appendButton('Link', Factory::getLanguage()->isRtl() ? 'arrow-right' : 'arrow-left', $alt, $href);
I prefer in 2 lines.
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-16 16:53:07 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
Thanks!
@richard67 yes, will do tomorrow
It should handle RTL.