User tests: Successful: Unsuccessful:
PR for #29621
apply the safari fix from the admin template #28921 to the installer
@nikosdion @PhilETaylor please test as I don't have access to safari
Dont forget to npm i or node build.js --compile-css
Status | New | ⇒ | Pending |
Category | ⇒ | Installation NPM Change |
It may well be but the fix is NOT in that file.
I know, so you can just add:
th {
text-align: -webkit-match-parent;
}
Rather than importing the entire reboot.scss
again
Rather than importing the entire reboot.scss again
I am not doing that - check the paths
Ah wrong template, sorry.
I am not doing that - check the paths
Actually you are doing exactly that. the line 6:
@import "../../../media/vendor/bootstrap/scss/bootstrap";
Already includes reboot, so you're including the same (-ish) file twice. Either:
@import "../../../media/vendor/bootstrap/scss/bootstrap";
to the individual imports and replace the reboot with the preferred one...please read the pr before commenting!!
even better test it
@brianteeman I'm sorry but the naming is really poor here. The file is not reboot
rather an add-on to reboot, so, unless someone really digs into the code it's rather frustrating. You could have named that as reboot-safari-fix
or something similar and things would be obvious. Naming that file as a known Bootstrap module and expect people to understand what's inside that file is a bit stressed to say the least...
it is named reboot because it follows the existing naming convention that I did not create.
I can't help it if people like to comment that something is wrong and doesnt work when they dont test it
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-17 15:29:20 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
NPM Resource Changed
?
|
Thanks!
The reboot is already being imported from inside the core BS SCSS file:
joomla-cms/installation/template/scss/template.scss
Line 6 in b0d7d59