NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
15 Jun 2020

PR for #29621

apply the safari fix from the admin template #28921 to the installer

@nikosdion @PhilETaylor please test as I don't have access to safari

Dont forget to npm i or node build.js --compile-css

avatar brianteeman brianteeman - open - 15 Jun 2020
avatar brianteeman brianteeman - change - 15 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Jun 2020
Category Installation NPM Change
avatar C-Lodder
C-Lodder - comment - 15 Jun 2020

The reboot is already being imported from inside the core BS SCSS file:

@import "../../../media/vendor/bootstrap/scss/bootstrap";

@import "reboot";
avatar brianteeman
brianteeman - comment - 15 Jun 2020

It may well be but the fix is NOT in that file.

avatar C-Lodder
C-Lodder - comment - 15 Jun 2020

I know, so you can just add:

th {
  text-align: -webkit-match-parent;
}

Rather than importing the entire reboot.scss again

avatar brianteeman
brianteeman - comment - 15 Jun 2020

Rather than importing the entire reboot.scss again

I am not doing that - check the paths

avatar C-Lodder
C-Lodder - comment - 15 Jun 2020

Ah wrong template, sorry.

avatar dgrammatiko
dgrammatiko - comment - 15 Jun 2020

I am not doing that - check the paths

Actually you are doing exactly that. the line 6:

@import "../../../media/vendor/bootstrap/scss/bootstrap";

Already includes reboot, so you're including the same (-ish) file twice. Either:

  • what @C-Lodder proposed above
  • or unpack @import "../../../media/vendor/bootstrap/scss/bootstrap"; to the individual imports and replace the reboot with the preferred one...
avatar brianteeman
brianteeman - comment - 15 Jun 2020

please read the pr before commenting!!
even better test it

avatar dgrammatiko
dgrammatiko - comment - 15 Jun 2020

@brianteeman I'm sorry but the naming is really poor here. The file is not reboot rather an add-on to reboot, so, unless someone really digs into the code it's rather frustrating. You could have named that as reboot-safari-fix or something similar and things would be obvious. Naming that file as a known Bootstrap module and expect people to understand what's inside that file is a bit stressed to say the least...

avatar brianteeman
brianteeman - comment - 15 Jun 2020

it is named reboot because it follows the existing naming convention that I did not create.

I can't help it if people like to comment that something is wrong and doesnt work when they dont test it

avatar wilsonge wilsonge - change - 17 Jun 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-06-17 15:29:20
Closed_By wilsonge
Labels Added: NPM Resource Changed ?
avatar wilsonge wilsonge - close - 17 Jun 2020
avatar wilsonge wilsonge - merge - 17 Jun 2020
avatar wilsonge
wilsonge - comment - 17 Jun 2020

Thanks!

avatar brianteeman
brianteeman - comment - 17 Jun 2020

Thanks @wilsonge

Add a Comment

Login with GitHub to post a comment