? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
15 Jun 2020

Pull Request for Issue #29039. Alternative PR to #29067.

Summary of Changes

Changes update description to use description from remote XML file instead of extension manifest.

Testing Instructions

Install some extension that uses updater, e.g. this https://github.com/C-Lodder/joomla4-backend-template/releases/download/v0.0.14/tpl_bettum-v0.0.14.zip.
Check for updates.
Hover over the update to see a tooltip.

Expected result

A dark themed administrator template for Joomla 4

Actual result

TPL_BETTUM_XML_DESCRIPTION

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 15 Jun 2020
avatar SharkyKZ SharkyKZ - change - 15 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Jun 2020
Category Administration com_installer
avatar SharkyKZ SharkyKZ - change - 15 Jun 2020
The description was changed
avatar SharkyKZ SharkyKZ - edited - 15 Jun 2020
avatar ChristineWk
ChristineWk - comment - 15 Jun 2020

Hmm. Got expected result without Patch:

pr29619

avatar SharkyKZ SharkyKZ - change - 15 Jun 2020
The description was changed
avatar SharkyKZ SharkyKZ - edited - 15 Jun 2020
avatar SharkyKZ
SharkyKZ - comment - 15 Jun 2020

Whoops, I mixed up expected/actual result. Testing instructions updated.

avatar ChristineWk ChristineWk - test_item - 15 Jun 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 15 Jun 2020

I have tested this item successfully on 24cea47


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29619.

Fetched again :-)

pr29619_02

avatar jwaisner jwaisner - test_item - 15 Jun 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 15 Jun 2020

I have tested this item successfully on 24cea47


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29619.

avatar jwaisner jwaisner - change - 15 Jun 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 15 Jun 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29619.

avatar richard67 richard67 - change - 15 Jun 2020
Labels Added: ? ?
avatar wilsonge wilsonge - change - 15 Jun 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-06-15 21:23:20
Closed_By wilsonge
Labels
avatar wilsonge wilsonge - close - 15 Jun 2020
avatar wilsonge wilsonge - merge - 15 Jun 2020
avatar wilsonge
wilsonge - comment - 15 Jun 2020

Seems logical - thanks!

avatar wilsonge
wilsonge - comment - 15 Jun 2020

Seems intentional from this - #25642 but looks like it works now so ?‍♂️

Add a Comment

Login with GitHub to post a comment