[#29613] - [4.0] Fix language strings for robots options
- Closed
- 15 Jun 2020
- Medium
- Build: 4.0-dev
- # 29613
- Diff
- richard67:4.0-dev-fix-language-strings-of-robots-options
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #29595 .
Summary of Changes
See #29595 (comment).
Same as #29612 does for J3, but this here is for J4.
Testing Instructions
Code review plus check diverse places where robots options appear (e.g. Global Configuration, tab "Site", section "Robots").
Expected result
The options are shown like they are specified to be used in the robots meta tag, see e.g. https://developers.google.com/search/reference/robots_meta_tag?hl=en.
They are marked in the language file by a comment as not to be translated.
Actual result
The robots option values are an inconsistent mix of upper and lowercase spelling.
They are not marked in the language file by a comment as not to be translated, so they might be translated by translation teams to anything.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
| Labels |
Added:
?
?
|
||
API file needed the same changes. Now this PR is ready for review/test.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29613.
I have tested this item
Confirmed: Robots drop down list in Global Configuration displays all lower case options.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29613.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29613.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29613.
I suggest to limit this to the api as #29612 will be forwarded to 4.0 when merged in 3.x
@infograf768 I leave it to George.
@wilsonge If you want to avoid merge conflicts, just cherry-pick the 2nd commit for the API language file and close the PR instead of mergin. Or shall I modify it?
@infograf768 Shall I remove RTC from this here because the reason you stated in your comment on the J3 PR also apply here?
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-15 21:43:32 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
@wilsonge
Feel free to close this PR here if it is sufficient to wait for PR #29612 popping of from staging with the next upmerge.Update: This here has also the changes in the API language file, this will not pop up from J3 ;-)