[#29611] - Fix for Note form field displaying description
- Closed
- 19 Jun 2020
- Medium
- Build: 4.0-dev
- # 29611
- Diff
- Ruud68:notefieldfix
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The Note field is used to display a note to the user in the configuration. The text in the note field comes from the description parameter.
Testing Instructions
Add a note field to e.g. a plugin config file with a label and description
verify that the description is both set in the note field as well as below the notefield as the 'description'
install this PR
verify that the description below the notefield is not displayed, but that all other descriptions on non-note fields are displayed
Expected result
The notefield should be displayed without the additional description below the note field (which is the same text as the note field itself)
Actual result
The description displays below the notefield as a description text doubling the information on the screen
Documentation Changes Required
no
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
Hi, it was either this, or create a new layout field for note. Good it was a PR and not the lottery :)
Will create a new layout field instead.
PS. Thanks :)
New layout field will NOT work because the description is ALWAYS added: either to the native form element or using a layout file for the form element.
So this cannot be overwritten in any other way.
That makes me think that the current implementation of renderfield.php is wrong as it always forces the description instead of having it as part of the layout file.
Any thoughts on this?
@brianteeman I have come up with a better solution: I have created a hiddenLegend attribute that can be set either in the xml or in the layout file.
This will give you full control on whether you want to display the legend (default is yes) or not, and it can be set as value in layout file for (e.g. the note field)
This is IMO the best way to do this as the alternative is to remvoe the legend from the renderfield layout and add it to ALL other layout files.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-19 12:40:16 |
| Closed_By | ⇒ | Ruud68 | |
| Labels |
Added:
?
|
||
This is not the correct fix. The problem as identified before is that the note field type is not using a layout and it should be.
PS you have a typo in your string