? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
12 Jun 2020

Summary of Changes

Apply Bootstrap markup to unlimited checkbox.

From Bootstrap migrating to v4:

Consolidated .checkbox and .radio into .form-check and the various .form-check-* classes.

Testing Instructions

Edit a banner.
Click Banner Details tab.

Expected result

unlimited-after

Actual result

unlimited-before

avatar Quy Quy - open - 12 Jun 2020
avatar Quy Quy - change - 12 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jun 2020
Category Administration com_banners
avatar brianteeman
brianteeman - comment - 12 Jun 2020

i thought we were trying to avoid using framework classes?

avatar Quy
Quy - comment - 12 Jun 2020

My understanding is that it is ok to use Bootstrap on the backend.

avatar wilsonge
wilsonge - comment - 12 Jun 2020

In the backend is fine

avatar ceford ceford - test_item - 13 Jun 2020 - Tested successfully
avatar ceford
ceford - comment - 13 Jun 2020

I have tested this item successfully on 10de8c4

I see the space between the checkbox and label. But shouldn't this be a Yes/No slide?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29587.

avatar ChristineWk ChristineWk - test_item - 13 Jun 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 13 Jun 2020

I have tested this item successfully on 10de8c4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29587.

avatar alikon alikon - change - 13 Jun 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 13 Jun 2020

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29587.

avatar wilsonge wilsonge - change - 13 Jun 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-06-13 10:13:15
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 13 Jun 2020
avatar wilsonge wilsonge - merge - 13 Jun 2020
avatar wilsonge
wilsonge - comment - 13 Jun 2020

Thanks!

Add a Comment

Login with GitHub to post a comment