?
avatar PhilETaylor
PhilETaylor
9 Jun 2020

Steps to reproduce the issue

Read a private message in Joomla admin

Expected result

Reply | Close

Because you close a screen, but you cancel an action. There is no action to be taken on this page, so it should be simply a close.

Actual result

Reply | Cancel

Screenshot 2020-06-09 at 20 42 09

System information (as much as possible)

BONUS

The opposite bug is true on the private message COMPOSE page where there is a Close button.

This is an action page, so the button should be a Cancel and not a close.

Screenshot 2020-06-09 at 20 43 04

avatar PhilETaylor PhilETaylor - open - 9 Jun 2020
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jun 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 9 Jun 2020
avatar PhilETaylor
PhilETaylor - comment - 9 Jun 2020

Hmmm... maybe subjective here, as Editing content has a close button, when ME PERSONALLY would say that also should be a cancel button. Feel free to just close this if you think that Im wrong. I'll not be offended.

But a decision on close/cancel should be made and universally applied one way or the other. At the moment there is not uniformity

You can't "close" an action page, you "cancel" out of an action page is my view on this.

You can "close" something that you are just reading..

For example, Banners - has a cancel on the New page...

Screenshot 2020-06-09 at 20 46 26

avatar PhilETaylor PhilETaylor - change - 9 Jun 2020
Title
[4.0] Cancel button should be a close button
[4.0] Cancel button should be a close button & vice-versa?
avatar PhilETaylor PhilETaylor - edited - 9 Jun 2020
avatar PhilETaylor
PhilETaylor - comment - 9 Jun 2020

Screenshot 2020-06-09 at 20 49 34

Screenshot 2020-06-09 at 20 47 46

Screenshot 2020-06-09 at 20 48 12

avatar brianteeman
brianteeman - comment - 25 Apr 2021

Cancel when its a new item
Close when its an existing item ?

avatar PhilETaylor
PhilETaylor - comment - 25 Apr 2021

Sounds right

avatar brianteeman
brianteeman - comment - 25 Apr 2021

That should be doable - putting it on my list

avatar brianteeman
brianteeman - comment - 25 Apr 2021

Can be closed see #33317

avatar PhilETaylor
PhilETaylor - comment - 25 Apr 2021

Thanks #33317

avatar PhilETaylor PhilETaylor - change - 25 Apr 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-04-25 18:20:46
Closed_By PhilETaylor
avatar PhilETaylor PhilETaylor - close - 25 Apr 2021

Add a Comment

Login with GitHub to post a comment