? ? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
9 Jun 2020

Pull Request for Issue #29502 .

Summary of Changes

Checking whether $component not empty

Testing Instructions

Apply patch, and follow any non existing URL, eg index.php?Itemid=429

Expected result

"Component not found" error

Actual result

WebAssetRegistry exception

Documentation Changes Required

none

avatar Fedik Fedik - open - 9 Jun 2020
avatar Fedik Fedik - change - 9 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jun 2020
Category Libraries
avatar ChristineWk ChristineWk - test_item - 9 Jun 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 9 Jun 2020

I have tested this item successfully on 8014ca5

Before applying Patch, Actual result:
0 Argument 1 passed to Joomla\CMS\WebAsset\WebAssetRegistry::addExtensionRegistryFile() must be of the type string, null given, called in/xxxxxx/libraries/src/Application/SiteApplication.php on line 173

With Patch, Expected result:
404 Component not found.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29530.

avatar Quy Quy - test_item - 9 Jun 2020 - Tested successfully
avatar Quy
Quy - comment - 9 Jun 2020

I have tested this item successfully on 8014ca5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29530.

avatar Quy Quy - change - 9 Jun 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 9 Jun 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29530.

avatar wilsonge wilsonge - change - 10 Jun 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-06-10 22:29:23
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge
wilsonge - comment - 10 Jun 2020

Thanks!

Add a Comment

Login with GitHub to post a comment