Feeling Lucky
?
?
[#29521] - [4.0] Create empty modules when template preview is enabled
- Fixed in Code Base
- 10 Jun 2020
- Medium
- Build: 4.0-dev
- # 29521
- Diff
- SharkyKZ:j4/dummy-module
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #29494.
Summary of Changes
When template preview is enabled and no module is published in a module position, a module based on position name is created in the position. This changes the module to an empty dummy module.
Testing Instructions
- Make sure no module is published in frontend
footerposition. Enable template preview. Inspect module positions. - Create an article. Use
{loadmoduleid}shortcode to insert module. One with existing ID and one with non-existing. - Go to Postinstall Messages in backend. Check that
Release news from the Joomla! Projectnewsfeed still appears.
Expected result
- Empty
footerposition is shown. - Works like before (existing module shows up, non-existing does not).
- Works like before. No notices.
Actual result
mod_footeris shown infooterposition (contents:Copyright © 2020 Joomla!. All Rights Reserved.).
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
Quy
- comment
- 9 Jun 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29521.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 9 Jun 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29521.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-10 22:32:33 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 10 Jun 2020
Thanks!
I have tested this item✅ successfully on e380b89
Tested successfully in 4.0-beta2-dev of 9 May.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29521.