Conflicting Files ? NPM Resource Changed ? ? Success

User tests: Successful: Unsuccessful:

avatar Didldu-Florian
Didldu-Florian
8 Jun 2020

Summary of Changes

Hey guys, the backend design needs a small but effective change.

See yourself

Before:
before2

After:
after2

--

Before:
before

After:
after

--

Before:
grafik

After:
grafik

If you like what you see, we can adapt these easy in all views next.
So, what about to take the PR ? ... next

avatar Didldu-Florian Didldu-Florian - open - 8 Jun 2020
avatar Didldu-Florian Didldu-Florian - change - 8 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Jun 2020
Category Administration Templates (admin) NPM Change
avatar Didldu-Florian Didldu-Florian - change - 8 Jun 2020
Title
New clean layout » separate sections ?
[4.0] New clean layout » separate sections ?
avatar Didldu-Florian Didldu-Florian - edited - 8 Jun 2020
avatar Didldu-Florian Didldu-Florian - change - 8 Jun 2020
Labels Added: NPM Resource Changed ?
avatar joomla-cms-bot joomla-cms-bot - change - 8 Jun 2020
Category Administration Templates (admin) NPM Change Administration com_content Templates (admin) NPM Change
avatar brianteeman
brianteeman - comment - 8 Jun 2020

LGTM

avatar Quy
Quy - comment - 8 Jun 2020

See red arrows where they don't look good.

29514

avatar Didldu-Florian
Didldu-Florian - comment - 9 Jun 2020

@Quy maybe, but it's not part of that PR and its same as before.
Anyway I think the new layout is a lot of smarter, takes more contrast beetween the sections and makes more use of the width on smaller devices.

Your Screenshot includes also not all changes, because it looks like this after the change:

After:
grafik

Before:
grafik

We have a straight left edge of the containers.
Please check with all style changes.

avatar infograf768
infograf768 - comment - 9 Jun 2020

I have unwanted consequences here when not using card but only <div class="col-md-12">

Before patch

Screen Shot 2020-06-09 at 11 05 01

After patch

Screen Shot 2020-06-09 at 11 11 01

Screen Shot 2020-06-09 at 11 05 41

avatar Didldu-Florian
Didldu-Florian - comment - 9 Jun 2020

@infograf768 yes, I know these, and it expects anyway a new pr to change the classes in the views.
Here we hefe different layouts, its anyway bad and have to be fixed anyway.

For example, after my changes, the cofig permissions looks like these:

grafik

So the question is, why we have anyway different layouts?
We should change all layouts to a uniform standard.
For these my pr could also help to detect the differences..
Next we can change the layouts which do not follow the standard.

avatar infograf768
infograf768 - comment - 9 Jun 2020

We can't expect a next step imho. Such a pr should deal with all situations.

avatar Didldu-Florian
Didldu-Florian - comment - 9 Jun 2020

Okay, I will check any view and will add the changes if needed in these PR nex...

avatar Didldu-Florian
Didldu-Florian - comment - 9 Jun 2020

@infograf768 which view of which component is the view in your screenshot?
I've checked now any view in current 4.0-dev branche. And it looks really fine, except for the view shown by you, which is unknown to me? Let me know and I will fix it. Finally I think, the PR is acceptable, because minor adjustments can still be made!

avatar uglyeoin
uglyeoin - comment - 17 Oct 2020

@infograf768 please can you answer @Didldu-Florian so we can test it as part of PBF

avatar priyankaSahutekdi priyankaSahutekdi - test_item - 7 Nov 2020 - Tested successfully
avatar priyankaSahutekdi
priyankaSahutekdi - comment - 7 Nov 2020

I have tested this item successfully on 1fac657

The design is looking so clean now


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29514.

avatar priyankaSahutekdi priyankaSahutekdi - test_item - 7 Nov 2020 - Not tested
avatar priyankaSahutekdi
priyankaSahutekdi - comment - 7 Nov 2020

I have not tested this item.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29514.

avatar Didldu-Florian Didldu-Florian - change - 7 Nov 2020
Labels Added: ?
avatar Didldu-Florian Didldu-Florian - change - 7 Nov 2020
Labels Added: ?
Removed: ?
avatar Didldu-Florian
Didldu-Florian - comment - 7 Nov 2020

@Quy , options-form legend border is now also added by 0fa941c

grafik

Final I don't know what all these discussions are about, because the design improves a lot of things.
And everything else can easily be followed up.

avatar Didldu-Florian Didldu-Florian - change - 7 Nov 2020
Labels Added: ?
Removed: ?
avatar Didldu-Florian Didldu-Florian - change - 7 Nov 2020
Labels Added: ?
Removed: ?
avatar Didldu-Florian
Didldu-Florian - comment - 7 Nov 2020

Can someone remove "Conflicting Files" Label? Thx

avatar Didldu-Florian Didldu-Florian - change - 7 Nov 2020
Title
[4.0] New clean layout » separate sections ?
[4.0] New clean layout » separate sections
avatar Didldu-Florian Didldu-Florian - edited - 7 Nov 2020
avatar Quy
Quy - comment - 10 Nov 2020

I find the highlighted/active tab distracting. For the side area, should it have a white background?

29514

avatar Didldu-Florian Didldu-Florian - change - 10 Nov 2020
Labels Added: ?
Removed: Conflicting Files ?
avatar joomla-cms-bot joomla-cms-bot - change - 10 Nov 2020
Category Administration Templates (admin) NPM Change com_content Administration com_content Templates (admin) NPM Change Layout
avatar Didldu-Florian
Didldu-Florian - comment - 10 Nov 2020

@Quy maybe better now:
grafik

Sorry for such a lot mimimis, there are so many things to do with that new design better as with the old one.
Finally for me it looks much more cleaner as the white striped style! So let it get into core next bevore the PR is fucked up! The mentioned things for me all right, of courese, but these are only small improvements, which can also be criticised in the current Design. I'm sure, any small criticised could be easy fixed after that also!

avatar Didldu-Florian Didldu-Florian - change - 10 Nov 2020
The description was changed
avatar Didldu-Florian Didldu-Florian - edited - 10 Nov 2020
avatar Didldu-Florian Didldu-Florian - change - 11 Nov 2020
Labels Added: ?
Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 11 Nov 2020
Category Administration Templates (admin) NPM Change com_content Layout Administration com_content Language & Strings Templates (admin) NPM Change Layout
avatar chmst
chmst - comment - 11 Nov 2020

Looks good - but I think that the legend "Global" is not good. I know that it is the fieldset name - and it is called so from developers who use these params everywhere. But what means "global" for users? @infograf768 , @brianteeman?

avatar brianteeman
brianteeman - comment - 11 Nov 2020

Without looking at the specific reference for this so that I can comment on the word only

Global is for the entire site.
eg Global Configuration
Use Global
etc

avatar chmst
chmst - comment - 11 Nov 2020

global

Maybe "Status" is better?

avatar brianteeman
brianteeman - comment - 11 Nov 2020

Now that I look at it - global is definitely wrong
Does it even need a text?

avatar chmst
chmst - comment - 11 Nov 2020

No, it doesn't. @Didldu-Florian can you remove the legend?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29514.

avatar Didldu-Florian
Didldu-Florian - comment - 11 Nov 2020

@chmst I can, the only problem is that afterwards we are not in line and have to push manually with px
grafik

I will suggest, using only fielset options-forms with legends, so we should find a good title, maybe?

avatar chmst
chmst - comment - 11 Nov 2020

So we need a good name for a quick solution. Controls?

On the other Hand - do we need the legend "Article Text" around the the text input? Isn't it self explaining also without legend?

avatar Didldu-Florian
Didldu-Florian - comment - 11 Nov 2020

For me "Controls" sounds good.
Of course we could also remove the other legend, but then you can basically think about removing some legends everywhere.

avatar infograf768
infograf768 - comment - 11 Nov 2020

Basic Parameters ?

avatar chmst
chmst - comment - 11 Nov 2020

Better than "Global". Let's take this.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29514.
avatar Didldu-Florian Didldu-Florian - change - 11 Nov 2020
Labels Added: ? ?
Removed: ?
avatar brianteeman
brianteeman - comment - 11 Nov 2020

For me the word parameters is wrong - but what does that matter

avatar ceford
ceford - comment - 18 Nov 2020

Article Settings?

I revised the Help screens for forms in recent months, many of them without legends. They are mostly referred to as Left and Right Panel. I would like to see the legends kept!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29514.

avatar Didldu-Florian
Didldu-Florian - comment - 18 Nov 2020

@ceford I think the same, we need uniform legends for all field sets.
But finnaly not in these PR, next... so it's a never ending story

avatar Quy
Quy - comment - 12 Apr 2021

Closing in favor of #33100. Thanks.

avatar Quy Quy - close - 12 Apr 2021
avatar Quy Quy - change - 12 Apr 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-04-12 03:36:03
Closed_By Quy
Labels Added: Conflicting Files ?
Removed: ?

Add a Comment

Login with GitHub to post a comment