User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) NPM Change |
Title |
|
Labels |
Added:
NPM Resource Changed
?
|
Category | Administration Templates (admin) NPM Change | ⇒ | Administration com_content Templates (admin) NPM Change |
@Quy maybe, but it's not part of that PR and its same as before.
Anyway I think the new layout is a lot of smarter, takes more contrast beetween the sections and makes more use of the width on smaller devices.
Your Screenshot includes also not all changes, because it looks like this after the change:
We have a straight left edge of the containers.
Please check with all style changes.
@infograf768 yes, I know these, and it expects anyway a new pr to change the classes in the views.
Here we hefe different layouts, its anyway bad and have to be fixed anyway.
For example, after my changes, the cofig permissions looks like these:
So the question is, why we have anyway different layouts?
We should change all layouts to a uniform standard.
For these my pr could also help to detect the differences..
Next we can change the layouts which do not follow the standard.
We can't expect a next step imho. Such a pr should deal with all situations.
Okay, I will check any view and will add the changes if needed in these PR nex...
@infograf768 which view of which component is the view in your screenshot?
I've checked now any view in current 4.0-dev branche. And it looks really fine, except for the view shown by you, which is unknown to me? Let me know and I will fix it. Finally I think, the PR is acceptable, because minor adjustments can still be made!
@infograf768 please can you answer @Didldu-Florian so we can test it as part of PBF
I have tested this item
The design is looking so clean now
I have not tested this item.
Labels |
Added:
?
|
Labels |
Added:
?
Removed: ? |
Labels |
Added:
?
Removed: ? |
Labels |
Added:
?
Removed: ? |
Can someone remove "Conflicting Files" Label? Thx
Title |
|
Labels |
Added:
?
Removed: Conflicting Files ? |
Category | Administration Templates (admin) NPM Change com_content | ⇒ | Administration com_content Templates (admin) NPM Change Layout |
@Quy maybe better now:
Sorry for such a lot mimimis, there are so many things to do with that new design better as with the old one.
Finally for me it looks much more cleaner as the white striped style! So let it get into core next bevore the PR is fucked up! The mentioned things for me all right, of courese, but these are only small improvements, which can also be criticised in the current Design. I'm sure, any small criticised could be easy fixed after that also!
Labels |
Added:
?
Removed: ? |
Category | Administration Templates (admin) NPM Change com_content Layout | ⇒ | Administration com_content Language & Strings Templates (admin) NPM Change Layout |
Looks good - but I think that the legend "Global" is not good. I know that it is the fieldset name - and it is called so from developers who use these params everywhere. But what means "global" for users? @infograf768 , @brianteeman?
Without looking at the specific reference for this so that I can comment on the word only
Global is for the entire site.
eg Global Configuration
Use Global
etc
Now that I look at it - global is definitely wrong
Does it even need a text?
No, it doesn't. @Didldu-Florian can you remove the legend?
So we need a good name for a quick solution. Controls?
On the other Hand - do we need the legend "Article Text" around the the text input? Isn't it self explaining also without legend?
For me "Controls" sounds good.
Of course we could also remove the other legend, but then you can basically think about removing some legends everywhere.
Basic Parameters ?
Better than "Global". Let's take this.
Labels |
Added:
?
?
Removed: ? |
For me the word parameters is wrong - but what does that matter
Article Settings?
I revised the Help screens for forms in recent months, many of them without legends. They are mostly referred to as Left and Right Panel. I would like to see the legends kept!
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-12 03:36:03 |
Closed_By | ⇒ | Quy | |
Labels |
Added:
Conflicting Files
?
Removed: ? |
LGTM