[#29508] - [4.0b1] Two Factor in Users List uses different icons
- Closed
- 9 Jun 2020
- Medium
- Build: staging
- # 29508
Steps to reproduce the issue
Enable the 2FA plugins in Joomla 4
visit the users list
Expected result
Consistent use of icons ticks and crosses
Actual result
different X and tick for non enabled two factor users
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-08 18:34:50 |
| Closed_By | ⇒ | PhilETaylor |
| Status | Closed | ⇒ | New |
| Closed_Date | 2020-06-08 18:34:50 | ⇒ | |
| Closed_By | PhilETaylor | ⇒ |
well I applied that patch with the patch tester and it did not resolve the problem for me. I'll try it again
Sometimes Patch Tester fails. You can use the download package/installer in the footer of the PR. Click Show all checks link where there is a Download link. https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/28075/downloads/32886/
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-09 20:23:57 |
| Closed_By | ⇒ | PhilETaylor |
Well if you are sure, I take your word for it.
@PhilETaylor patch tester doesn't do npm ci which is needed in this case.
Thank you
Sent from my iPhone
On 10 Jun 2020, at 01:03, Bear notifications@github.com wrote:
@PhilETaylor patch tester doesn't do npm ci which is needed in this case.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
pretty sure this is fixed by #28075