No Code Attached Yet
avatar PhilETaylor
PhilETaylor
8 Jun 2020

Steps to reproduce the issue

Try to create a folder in media manager in Joomla 4

Test 1: Try to create a folder with the name of a folder that already exists.
Test 2: Try to create a folder called ../tmp/something

Expected result

Test 1: "Error: A Folder already exists with that name"
Test 2: "You cannot use relative paths"

Actual result

Test 1: Generic Error message and JSON XHR response of {"success":false,"message":"","messages":null,"data":null}

Screenshot 2020-06-08 at 17 34 35

Test 2: Generic Error Message, and a blank space above message and JSON AJAX response of

{"success":false,"message":"Joomla\\CMS\\Filesystem\\Path::check() - Use of relative paths not permitted","messages":null,"data":null}

Screenshot 2020-06-08 at 17 40 27

System information (as much as possible)

Additional comments

avatar PhilETaylor PhilETaylor - open - 8 Jun 2020
avatar joomla-cms-bot joomla-cms-bot - change - 8 Jun 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 8 Jun 2020
avatar ghost
ghost - comment - 21 Sep 2020
  • Issue 1 confirmed.
  • Issue 2 a blank space above messageconfirmed, message is:
    Screenshot_2020-09-21 Media - fw4 - Administration(1)
avatar PhilETaylor
PhilETaylor - comment - 25 Apr 2021

Tested again today.

Issue 1 is that when you attempt to create a folder that already exists the modal hides the error message and a console.log message is also logged.

Screenshot 2021-04-25 at 17 04 45


Issue two, when trying to create a folder called ../tmp/something the modal background hides the issue like the issue 1 above, however also the PHP Classname and Method name are exposed and we should not be displaying PHP Classnames/methods in error messages - we have removed a few of these recently - its not user friendly.

There is no longer a blank space above the message, you get a generic "Error creating folder" message in that space today.

Again the console.log message needs removing

Screenshot 2021-04-25 at 17 11 09

avatar dgrammatiko
dgrammatiko - comment - 25 Apr 2021

Issue 1 is that when you attempt to create a folder that already exists the modal hides the error message and a console.log message is also logged.

The problem is that the message should be rendered inside the modal

Again the console.log message needs removing

All the console logs were placeholders, there should be a better way to handle the errors. I'll have a look on the reported issues later this week unless someone is faster

avatar laoneo
laoneo - comment - 24 Jun 2021

@dgrammatiko would it help to move the system message element into the modal?

avatar dgrammatiko
dgrammatiko - comment - 9 Nov 2021

This should have been fixed

avatar brianteeman
brianteeman - comment - 9 Nov 2021

The modal still hides the error message as reported #29499 (comment) and the 409 conflict reported still exists

avatar PhilETaylor PhilETaylor - change - 7 Mar 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-03-07 18:39:56
Closed_By PhilETaylor
Labels Added: No Code Attached Yet
Removed: ?
avatar PhilETaylor PhilETaylor - close - 7 Mar 2022

Add a Comment

Login with GitHub to post a comment