[#29493] - [4.0] Featured button: Swap popover title and body
- Fixed in Code Base
- 13 Jun 2020
- Medium
- Build: 4.0-dev
- # 29493
- Diff
- chmst:popover-featured-state
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Show the title and body in the right place
Testing Instructions
Compare the popvers of featured and status button before and after Patch.
The popover of the featured button after patch is like the status button
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
This should not be using a popover at all for all the reasons we have discussed before and should be using the accessible method used elsewhere. These were not changedat the time of everything else as they were impacted by workflows and it wasnt worth doing it until it was known if workflows was to be replaced, reverted etc
@brianteeman you are right. I have no solution for the whole problem at the moment. This small fix is only a little step to make it look less confusing.
@brianteeman Well, I wasn't involved in that discussion, or at least don't remember it now. I just saw this PR changes it as described. Do we have a link to the discussion?
Given the strings and popups already exist merging this. But accept we probably need to work on the a11y overall separately.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-13 17:10:21 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 551d779
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29493.