Feeling Lucky
?
[#2949] - Avoid log file failures breaking Joomla
- Closed
- 29 Mar 2014
- Medium
- Build: staging
- # 2949
- Diff
- garyamort:ignoreLogFailure
- Failure The Travis CI build failed Details
User tests: Successful: Unsuccessful:
Clean commit fix which resolves the log issues by replacing the platform JLog with a CMS specific JLog which suppresses RuntimeExceptions when saving log entries.
garyamort
- comment
- 3 Feb 2014
I don't really care where it goes, I just always lean towards not editing 'core' code. :-)
I'll rejigger it and push it.
garyamort
- comment
- 3 Feb 2014
Moved to platform directory
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-03-29 20:04:23 |
Can we just dump this code into the existing
JLogclass? There's potential issues with having twoJLogclasses in the file system (for example, if you're running a CLI script and don't run the CMS bootstrap, which would get this version ofJLogloaded into the filesystem). I'd rather comments inline or in the doc blocks where needed to see where exactly the CMS is needing to "hack" JLog to work properly, and it makes it easier to actually see the code differences (right now, it's a whole new file; I can't tell what changed just by looking at this diff).