Feeling Lucky
?
[#29486] - [4.0] Fix filtering banners by keywords
- Fixed in Code Base
- 12 Jun 2020
- Medium
- Build: 4.0-dev
- # 29486
- Diff
- SharkyKZ:j4/query/banners
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Fixes filtering banners by keywords. Similar to #29466.
Testing Instructions
Create a banner client.
Create a banner. Assign to a client. Add a keyword, e.g. Joomla.
Set some keywords for the document. Make sure the last keyword is not the same as the one set in the banner. E.g. add this to templates/cassiopeia/index.php:
$this->setMetadata('keywords', 'Joomla, CMS');
Publish a banner module. Enable Select by Keyword option.
View the module in frontend.
Expected result
Banner shown.
Actual result
Banner not shown.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_banners |
ChristineWk
- comment
- 12 Jun 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29486.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-12 23:52:40 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 12 Jun 2020
Thanks!
Was not sure where to add,
So, added above line (Instructions) templates/cassiopeia/index.php: to this place:
$app = Factory::getApplication();
$lang = $app->getLanguage();
$wa = $this->getWebAssetManager();
$this->setMetadata('keywords', 'Joomla, CMS');