[#29480] - [4.0] Filtering by core extensions returns non-core extensions
- Fixed in Code Base
- 8 Jun 2020
- Medium
- Build: 4.0-dev
- # 29480
- Diff
- SharkyKZ:j4/query/core-extensions
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Filtering by core extensions uses only element, which is not unique. This fixes that.
A method for getting core extension IDs was added to Joomla\CMS\Extension\ExtensionHelper.
Testing Instructions
Copy a template.
Give it a name of some element used by a core extension, e.g. sef, joomla, highlight, etc.
View installed extensions.
Filter by core and non-core extensions.
Expected result
The copied template appears when filtering by non-core extensions.
Actual result
The copied template appears when filtering by core extensions.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer |
The copied name should be joomla, not joomla_copy. But please wait with testing. I will update this PR shortly.
| Labels |
Added:
?
|
||
| Category | Administration com_installer | ⇒ | Administration com_installer com_joomlaupdate Libraries |
PR updated.
I have tested this item
OK now - with "joomla" only :-)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29480.
I have tested this item
Tested with MySQL and PostgreSQL.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29480.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29480.
| Labels |
Added:
?
|
||
Previous test results and RTC are still valid because last change was just code style. Added back the test results in the issue tracker.
@richard67
ah, I see. Wanted just know, to check via Code review :-)
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-08 12:00:29 |
| Closed_By | ⇒ | wilsonge |
Thankyou!
hmmm ... without Patch I have "Expected result". Should I use another name for? :-)