User tests: Successful: Unsuccessful:
Pull Request for Issue # .
The workflow plugins have been forgotten to be added to the list of core extensions in ExtensionsHelper class.
This Pull Request (PR) corrects that.
On an installation of a clean, current 4.0-dev branch or latest nightly or a 4.0 Beta 1, login to backend and go to the Joomla Update component.
In the component's options, change the update channel to "Custom URL", enter the 4.0 nightlies update URL https://update.joomla.org/core/nightlies/next_major_list.xml and save.
Check the extensions section of the pre-update check.
Result:
Apply the patch of this PR.
Check again the extensions section of the pre-update check.
Result:
None.
From my point of view, the testing sample data plugin also has to be added to the list of core extensions in the ExtensionsHelper class.
But I don't remember now who of you two, @SharkyKZ or @Quy , one of you was against it in a past discussion because this extension is not available and installed if not on a git clone. Now you can see what the consequence is. But when it is added, there are no negative side effects because we nowhere just fetch and output the list of core extensions, we only use it to check installed extenions. @wilsonge Please check, too, and comment.
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
RTC.
one of you was against it in a past discussion because this extension is not available and installed if not on a git clone
It was me. Because core extensions cannot be uninstalled, I expect Joomla\CMS\Extension\ExtensionHelper::getCoreExtensions()
to return only existing extensions.
Because core extensions cannot be uninstalled, I expect
Joomla\CMS\Extension\ExtensionHelper::getCoreExtensions()
to return only existing extensions.
Not installed extensions also cannot be uninstalled
Let me know if I could convince you with my arguments above or if you still think the same.
I am ok with anything, just that I think I'm right
Thank you @richard67!
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-08 07:18:18 |
Closed_By | ⇒ | infograf768 | |
Labels |
Added:
?
|
Tks.
I have tested this item✅ successfully on 70359bc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29478.