? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
7 Jun 2020

Pull Request for Issue # .

Summary of Changes

The workflow plugins have been forgotten to be added to the list of core extensions in ExtensionsHelper class.

This Pull Request (PR) corrects that.

Testing Instructions

  1. On an installation of a clean, current 4.0-dev branch or latest nightly or a 4.0 Beta 1, login to backend and go to the Joomla Update component.

  2. In the component's options, change the update channel to "Custom URL", enter the 4.0 nightlies update URL https://update.joomla.org/core/nightlies/next_major_list.xml and save.

  3. Check the extensions section of the pre-update check.

Result:

  • Beside 3rd party extenions, also the 3 workflow plugins are listed, see the extensions marked with a red frame in the screenshot in section "Actual result" below.
  • On a git clone, the testing sample data extenion is listed, too, see extension marked with an orange frame in the screenshot in section "Actual result" below.
  1. Apply the patch of this PR.

  2. Check again the extensions section of the pre-update check.

Result:

  • On a git clone, the testing sample data extenion is listed, too, see extension marked with an orange frame in the screenshot in section "Expected result" below.
  • No other core extensions are listed, only 3rd party extensions.

Expected result

j4-missing-core-extensions_corrected

Actual result

j4-missing-core-extensions

Documentation Changes Required

None.

Additional information

From my point of view, the testing sample data plugin also has to be added to the list of core extensions in the ExtensionsHelper class.

But I don't remember now who of you two, @SharkyKZ or @Quy , one of you was against it in a past discussion because this extension is not available and installed if not on a git clone. Now you can see what the consequence is. But when it is added, there are no negative side effects because we nowhere just fetch and output the list of core extensions, we only use it to check installed extenions. @wilsonge Please check, too, and comment.

avatar richard67 richard67 - open - 7 Jun 2020
avatar richard67 richard67 - change - 7 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Jun 2020
Category Libraries
avatar richard67 richard67 - change - 7 Jun 2020
The description was changed
avatar richard67 richard67 - edited - 7 Jun 2020
avatar brianteeman brianteeman - test_item - 7 Jun 2020 - Tested successfully
avatar brianteeman
brianteeman - comment - 7 Jun 2020

I have tested this item successfully on 70359bc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29478.

avatar SharkyKZ SharkyKZ - test_item - 7 Jun 2020 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 7 Jun 2020

I have tested this item successfully on 70359bc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29478.

avatar SharkyKZ SharkyKZ - change - 7 Jun 2020
Status Pending Ready to Commit
Labels Added: ?
avatar SharkyKZ
SharkyKZ - comment - 7 Jun 2020

RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29478.

avatar SharkyKZ
SharkyKZ - comment - 7 Jun 2020

one of you was against it in a past discussion because this extension is not available and installed if not on a git clone

It was me. Because core extensions cannot be uninstalled, I expect Joomla\CMS\Extension\ExtensionHelper::getCoreExtensions() to return only existing extensions.

avatar richard67
richard67 - comment - 7 Jun 2020

Because core extensions cannot be uninstalled, I expect Joomla\CMS\Extension\ExtensionHelper::getCoreExtensions() to return only existing extensions.

Not installed extensions also cannot be uninstalled ? . If we would use the pure output of the core extensions list for something and would expect the extensions in that list are all installed, then yes, then it would be wrong. But we have such code nowhere. We always use this list only to check if an installed extension is core or not.

Let me know if I could convince you with my arguments above or if you still think the same.

I am ok with anything, just that I think I'm right ?

avatar chmst
chmst - comment - 8 Jun 2020

Thank you @richard67!

avatar infograf768 infograf768 - close - 8 Jun 2020
avatar infograf768 infograf768 - merge - 8 Jun 2020
avatar infograf768 infograf768 - change - 8 Jun 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-06-08 07:18:18
Closed_By infograf768
Labels Added: ?
avatar infograf768
infograf768 - comment - 8 Jun 2020

Tks.

Add a Comment

Login with GitHub to post a comment