? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
6 Jun 2020

@wilsonge sorry had no time to make it before beta1, I hope it still okay. Other components I try to finish next week.

Summary of Changes

This make components to use WebAsset,
Affected components:

com_content
    /administrator/index.php?option=com_content&view=articles
    /administrator/index.php?option=com_content&view=featured
    /administrator/index.php?option=com_content&view=article&layout=edit

com_categories
    /administrator/index.php?option=com_categories&view=categories&extension=com_content
    /administrator/index.php?option=com_categories&view=category&layout=edit&id=2&extension=com_content

com_associations
    /administrator/index.php?option=com_associations&view=associations
    /administrator/index.php?option=com_associations&view=associations&layout=modal
    /administrator/index.php?option=com_associations&view=association&layout=edit&itemtype=com_content.article&task=association.edit&id=70 (edit)

com_fields
    /administrator/index.php?option=com_fields&view=fields
    /administrator/index.php?option=com_fields&view=fields&layout=modal (popup)
    /administrator/index.php?option=com_fields&view=field&layout=edit&context=com_content.article

com_contact
    /administrator/index.php?option=com_contact&layout=modal
    /administrator/index.php?option=com_contact&view=contact&layout=edit

com_contenthistory
com_tags
com_users
com_banners
com_newsfeeds

Testing Instructions

Apply patch, run npm install
Navigate around the site, try create/edit content in the component from the list
Inspect source code, you should see component scripts loaded.

Expected result

All works

Actual result

All works

ref #22435

avatar Fedik Fedik - open - 6 Jun 2020
avatar Fedik Fedik - change - 6 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jun 2020
Category Administration com_associations com_banners com_categories com_contact com_content com_contenthistory com_fields
avatar wilsonge
wilsonge - comment - 6 Jun 2020

It's fine to get this in but needs two testers now rather than just me doing review. so you'll need to add test instructions here

avatar Fedik
Fedik - comment - 6 Jun 2020

the instruction always there ?

avatar Fedik Fedik - change - 7 Jun 2020
Labels Added: ?
avatar Fedik Fedik - change - 13 Jun 2020
The description was changed
avatar Fedik Fedik - edited - 13 Jun 2020
avatar wilsonge wilsonge - change - 29 Jun 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-06-29 21:45:01
Closed_By wilsonge
avatar wilsonge wilsonge - close - 29 Jun 2020
avatar wilsonge wilsonge - merge - 29 Jun 2020
avatar wilsonge
wilsonge - comment - 29 Jun 2020

Thanks!

Add a Comment

Login with GitHub to post a comment