[#29453] - [4.0] Fix RTL tree select styling
- Fixed in Code Base
- 8 Jun 2020
- Medium
- Build: 4.0-dev
- # 29453
- Diff
- infograf768:4.0_rtl_treeselect
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #29438
Summary of Changes
Correcting rtl css
Needs npm ci
Testing Instructions
Install Persian language and switch to Persian in backend
Edit a site module =>Menu Assignments
Display 3rd choice in dropdown
Before patch
After patch
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
The flags are epiphenomenic. If they don’t show, it just means you may not have set the menu items correctly.
This PR does not concerns the flags but the menu items tree.
the pr can be tested on a monolingual site where Persian is installed and chosen as backend language.
I have tested this item
Without PR, elements in the tree for menu assingment are not indented according to their level in the tree when RTL.
With the PR (and npm ci), elements in the tree for menu assingment are indented correctly according to their level in the tree when RTL.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29453.
| Labels |
Added:
NPM Resource Changed
?
|
||
@ciar4n
done.
@richard67
please test again.
Note: I have a PR ready concerning the chevron for rtl (in js). I guess it is better to first merge this.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29453.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29453.
| Status | Pending | ⇒ | Ready to Commit |
rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29453.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-08 12:02:43 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I have set the entire site in multi language with the default language in question.
I went to module =>Menu Assignments of a generic module and I don't see the multi language flag with PR enabled.
I've enabled all the multi language plugins.
Are there other settings to set?