[#29416] - Fix array offset notice on PHP 7.4 when installing extensions
- Fixed in Code Base
- 15 Jun 2020
- Medium
- Build: staging
- # 29416
- Diff
- SharkyKZ:j3/notice/installer
User tests: Successful: Unsuccessful:
Partial Pull Request for Issue #29414.
Summary of Changes
Fixes a notice on PHP 7.4 when uploading extension package fails.
Testing Instructions
- Install an extension package with size over
upload_max_filesizelimit. Check PHP error log. - Try to install a random file, e.g. an image. Check Joomla's tmp directory.
- Install an extension with size under
upload_max_filesizelimit.
Expected result
- Installation aborted. No PHP notices.
- Installation aborted and uploaded file is removed from tmp directory.
- Extension installed successfully.
Actual result
- Installation aborted. PHP notice:
Trying to access array offset on value of type bool in administrator\components\com_installer\models\install.php on line 178
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer |
| Labels |
Added:
?
|
||
@richard67 The notice is not visible. You have to check PHP error log.
@SharkyKZ I always check PHP error log and have error reporting set to maximum in the backend. In my php.ini file I have E_ALL & ~E_DEPRECATED & ~E_STRICT, and I have log_errors = On; in my php.ini and a path to a log file set, which I watch permanently when testing and which shows me all. But the notice mentioned here I did not see.
@richard67 You're right. It's only on PHP 7.4+.
| Title |
|
||||||
Code change looks fine.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29416.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29416.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29416.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-15 21:40:08 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
@SharkyKZ For some reason I don't get the PHP notice of issue 1. with PHP 7.3. I get the correct red alert telling that maximum PHP file upload size is too small.