? NPM Resource Changed ? Failure

User tests: Successful: Unsuccessful:

avatar coolcat-creations
coolcat-creations
3 Jun 2020

Pull Request for Issue #29025 .

Summary of Changes

Adding Submenu css to the menu

Testing Instructions

not for final testing yet
collaboration is welcome

open issues:

  • mobile submenu
  • maximum levels?
  • javascript needed?

Expected result

Multilevel Dropdown in cassopeia possible

grafik

Actual result

no submenu possible at all

avatar coolcat-creations coolcat-creations - open - 3 Jun 2020
avatar coolcat-creations coolcat-creations - change - 3 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jun 2020
Category Modules Front End Templates (site)
avatar coolcat-creations coolcat-creations - change - 3 Jun 2020
Title
Add submenu
[4.0] Frontent Template Cassopeia - Add submenu dropdown
avatar coolcat-creations coolcat-creations - edited - 3 Jun 2020
avatar coolcat-creations coolcat-creations - change - 3 Jun 2020
Title
[4.0] Frontent Template Cassopeia - Add submenu dropdown
[4.0] Frontend Template Cassopeia - Add submenu dropdown
avatar coolcat-creations coolcat-creations - edited - 3 Jun 2020
avatar coolcat-creations coolcat-creations - change - 4 Jun 2020
Labels Added: ?
avatar richard67
richard67 - comment - 4 Jun 2020

@coolcat-creations Currently it seems to work only with 2 levels. If having 3 menu item levels, the 2nd level dropdown properly opens if having selected the first level, but the dropdown for the 3rd level doesn't open when selecting the 2nd level menu item in the 2nd level drop down.

avatar coolcat-creations
coolcat-creations - comment - 4 Jun 2020

I am not very satisfied about it at all and asked someone from the GER Community to help, I hope a better PR will follow. I would know how to solve it for client projects but here it has to work generally for everything possible and OC withouth jQuery - I don't know how to solve it in the best way :-)

avatar richard67
richard67 - comment - 4 Jun 2020

I wish I could help, but I'm not expert in this stuff.

avatar ChristineWk
ChristineWk - comment - 4 Jun 2020

@coolcat-creations
I'm afraid - can't also help further ....
Tried something and got following result (screenshot) maybe belongs to scss - NPM needed?

@richard67
It was possible, when selecting the 3rd sub-menue to select the 2nd sub-menue.

OT or not - bug or feature :-) with following steps:

a) "Parent Item" > e.g. Blog
b) "Menue Item Type" > ...... etc. (I took single article only)
c) "The Parent Item" changed back to: "Menu Item Root"
d) so, to start again with a)

submenues

avatar richard67
richard67 - comment - 4 Jun 2020

@ChristineWk For this PR here you need to run npm, that's right.

avatar dgrammatiko
dgrammatiko - comment - 4 Jun 2020

javascript needed?

JS is needed at least for accessibility (would be nice that the code would be BS js free as well). FWIW whenever a dropdown opens you need to set some aria-expanded, take care of the the tabstate and focus on the first a tag. As is, this completely breaks a11y...

avatar brianteeman
brianteeman - comment - 4 Jun 2020

luckily bootstrap 4 deals with all of that for me ;)

avatar astridx
astridx - comment - 14 Jun 2020

I also believe that we cannot deliver the Cassiopeia menu as it is at the moment.
Does anyone know where and why it was decided that Boostrap is not used in Cassiopeia? And why are we still loading Boostrap in the head of Cassiopeia?

avatar C-Lodder
C-Lodder - comment - 14 Jun 2020

@astridx What parts of Cassiopeia aren't using BS apart from the core grid?

avatar astridx
astridx - comment - 14 Jun 2020

@C-Lodder What parts of Cassiopeia aren't using BS apart from the core grid?

I ask because I understood Brian's comment that Cassiopeia shouldn't use Boostrap. Did I misunderstand that?

avatar C-Lodder
C-Lodder - comment - 15 Jun 2020

@astridx He was saying that BS takes care of the accessibility for dropdowns.

avatar ckubs
ckubs - comment - 1 Jul 2020

Making already something nice out of Cassiopeia( on beta 2) decided to stick with it for my new site. Bumped on this thread as the only issue I have is the lack of dropdowns for the main menu.

I managed to enable dropdowns using this snippet, on click. Unfortunatelly I don't have the necesarry jQuery knowledge to make a span inside .nav-item.deeper clickable to open the dropdown. Instead of the actual link wich may be a parent category that should open it's URL.

If someone knows wether Cassiopeia wil have proper menu dropdowns officialy to wait a littlew or is willing to give a little help, I'm gratefull. :)

avatar astridx
astridx - comment - 3 Jul 2020

Please see #29929

avatar david0296 david0296 - test_item - 4 Aug 2020 - Tested successfully
avatar david0296
david0296 - comment - 4 Aug 2020

I have tested this item successfully on 0116f38

After applying the pr, I was able to create multi-level dropdown-menus as shown in the screenshot



joomla


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29413.

avatar infograf768
infograf768 - comment - 4 Aug 2020

RTL ?

avatar coolcat-creations
coolcat-creations - comment - 4 Aug 2020

I don't know if I made it clear in the initial post. This PR is far from being good. It would be great if someone could help to create a good menu with a dropdown or even better a megamenu. In Glip we have a public chat about cassiopeia anyone can join to discuss how to improve it.

avatar chmst
chmst - comment - 11 Aug 2020

Work in progress for cassiopeia.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29413.

avatar brianteeman
brianteeman - comment - 11 Aug 2020

If you change the pr to draft status to indicate it is still a work in progress it would be helpful

avatar Magnytu2
Magnytu2 - comment - 16 Aug 2020

Hello everyone, once again I'm playing with J4 and the menus. But there is no change for the submenu. Do you have a close solution?
Positions_des_modules-3

avatar infograf768
infograf768 - comment - 16 Aug 2020

@Magnytu2
Cirylle, please read "Draft" near the title. It means this PR is not ready. Be patient.

avatar Magnytu2
Magnytu2 - comment - 16 Aug 2020

@ Magnytu2
Cirylle, veuillez lire " Brouillon " à côté du titre. Cela signifie que ce PR n'est pas prêt. Sois patient.

Sorry, here it is no longer the patient with Joomla! 4. It gets depressing. I want to help the community, to show the progress of Joomla, but each time I am disappointed. It becomes difficult to support Joomla.

avatar richard67
richard67 - comment - 16 Aug 2020

As said, someone is working on it and we will see results soon. Stay tuned.

avatar Magnytu2
Magnytu2 - comment - 16 Aug 2020

Comme dit, quelqu'un y travaille et nous verrons bientôt des résultats. Restez à l'écoute.

Thank you, I am. My Joomanji.fr site is just there for that. To show, help, create with Joomla 4. Except I don't know what to show and how to encourage Joomla?

avatar web-eau-net
web-eau-net - comment - 16 Aug 2020

This PR have been created by coolcat-creations the 3rd June.
Today is 16th Aug.
Please be patient @Magnytu2 be very patient.... ?

avatar richard67
richard67 - comment - 16 Aug 2020

Well you guys write that you want to know how to help. I will soon provide a link to our ongoing work where everybody can discuss and contribute. But complaining again doesn't help, I think. If there has been something said before, it is not useful to repeat and repeat it again.

avatar web-eau-net
web-eau-net - comment - 16 Aug 2020

3rd Jun - 16th Aug,...

avatar Magnytu2
Magnytu2 - comment - 16 Aug 2020

I'm not a developer, but I'll be happy to test your changes. Not with Joomla's PRs and the like. It's completely inaccessible to users like me. But if you have a template in .zip format that I can install, and set up several sites to make simulations, it will be easy.

avatar astridx
astridx - comment - 16 Aug 2020

I'm not a developer, but I'll be happy to test your changes. Not with Joomla's PRs and the like. It's completely inaccessible to users like me. But if you have a template in .zip format that I can install, and set up several sites to make simulations, it will be easy.

@Magnytu2 I agree with you. Testing a PR is complicated. But what exactly do you mean with "Not with Joomla's PRs and the like". Do you know that you can download a zipped version of Joomla -in PR available- for testing? And if no JS or SCSS File is changed you mostly can use https://github.com/joomla-extensions/patchtester.

4 0 Frontend Template Cassopeia Add submenu dropdown by coolcat creations · Pull Request 29413 · joomla joomla cms(1)

avatar astridx
astridx - comment - 16 Aug 2020

This PR have been created by coolcat-creations the 3rd June.
Today is 16th Aug.
Please be patient @Magnytu2 be very patient.... -1

@web-eau-net
A long period of time, that's true. But who do you think is responsible for building the drop down?

By the way, I submitted a working solution. It is linked in this PR. My PR has not been tested. I received two responses. In my opinion that is little. As I see it, both respnses are not relate to the code, rather it was more about preferences (Boostrap, Query or not, no further dependency without presenting the solution who alternatively programmed ...)

avatar joomla-cms-bot joomla-cms-bot - change - 16 Aug 2020
Category Modules Front End Templates (site) Modules Front End Templates (site) NPM Change
avatar Magnytu2
Magnytu2 - comment - 16 Aug 2020

@astridx No I am sorry. Github is an occult place, completely inaccessible and incomprehensible. Even for me who defines myself as a handyman, I dare not touch or say anything. For fear of doing stupid things or offending someone. I'm only testing what I can figure out by installing a Joomla or extension. And I'm just screaming at my sadness to see Joomla bogged down, losing users, and failing to communicate.

avatar bato3
bato3 - comment - 24 Sep 2020

@coolcat-creations it also require changes in /media/mod_menu/js/menu.js to add keyboard support for dropdown open

avatar ceford
ceford - comment - 18 Nov 2020

For my own J4 needs I made a clone of Cassiopeia and used Smartmenus (https://www.smartmenus.org/) which requires jQuery. I needed to revise the header and banner area layout to - but that is an aside. I only wanted one drop-down level, although it could do more. I am quite satisfied with the result - responsive and accessible. I am not suggesting that Joomla should use it, just that there are other solutions out there.

screen shot 2020-11-18 at 12 11 29


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29413.

avatar richard67
richard67 - comment - 18 Nov 2020

@ceford The frontend-template-working-group is on the way to finish their works on https://github.com/joomla/cassiopeia, which will result in a pull request for the 4.0-dev branch here in the CMS repository. The work includesd an accessible drop-down menu based on metismenujs, the vanilla JS version of metismenu. Metismenujs is already shipped with the CMS for the backend, and so it doesn't introduce a new dependency on another 3rd party product.

avatar richard67
richard67 - comment - 18 Nov 2020

P.S.: We don't want to introduce another dependency on jQuery and another external dependency to a 3rd party product.

avatar ceford
ceford - comment - 18 Nov 2020

I just remembered that I sought an alternative menu solution because the then Cassiopeia menu was not suitable for my needs. That must have been early this year. I look forward to testing the metsmenu based menu in due course.

avatar chmst
chmst - comment - 21 Nov 2020

@coolcat-creations is this still work in progress for you?

avatar richard67
richard67 - comment - 28 Nov 2020

The Frontend Template Working Group (JEDT - FT) has finished their works on the https://github.com/joomla/cassiopeia repository and just created PR #31520 , which includes also an accessible dropdown menu for the frontend.

@coolcat-creations and others: I'd be happy if you could test our PR.

avatar Quy
Quy - comment - 1 Dec 2020

@richard67 Close?

avatar richard67
richard67 - comment - 1 Dec 2020

@Quy In principle yes, because now after the Cassiopeia enhancements with the dropdown menu has been merged, this PR is obsolete. On the other hand I prefer to leave that to authors.

avatar coolcat-creations coolcat-creations - change - 19 Dec 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-12-19 12:42:19
Closed_By coolcat-creations
Labels Added: ?
avatar coolcat-creations coolcat-creations - close - 19 Dec 2020

Add a Comment

Login with GitHub to post a comment