?
avatar GixxerMKD
GixxerMKD
2 Jun 2020

Steps to reproduce the issue

Fresh beta 1 installation
Tried to install one of JoomShaper's template to see what will happen (template version J3.x)

Expected result

Error message regarding the unsupported extension (version).

Actual result

An error has occurred.
0 Call to undefined method Joomla\CMS\Application\AdministratorApplication::isAdmin()
Back-end shows the error message on all screens, cannot do anything in the admin.

System information (as much as possible)

Local installation (wamp) php 7.3.1, mysql 5.7.24, apache 2.4.37

Additional comments

avatar GixxerMKD GixxerMKD - open - 2 Jun 2020
avatar joomla-cms-bot joomla-cms-bot - change - 2 Jun 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 2 Jun 2020
avatar GixxerMKD GixxerMKD - change - 2 Jun 2020
Title
Error: 0, after trying to install joomla 3.x template
[4.0b1] Error: 0, after trying to install joomla 3.x template
avatar GixxerMKD GixxerMKD - edited - 2 Jun 2020
avatar SharkyKZ
SharkyKZ - comment - 2 Jun 2020

This should be reported to JoomShaper. It's up to extensions to handle compatibility with Joomla! versions. Closing as non-core issue.

avatar SharkyKZ SharkyKZ - change - 2 Jun 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-06-02 21:08:11
Closed_By SharkyKZ
avatar SharkyKZ SharkyKZ - close - 2 Jun 2020
avatar github-canni
github-canni - comment - 25 Sep 2020

@SharkyKZ So installing an extension by a user could possibly corrupt the whole installation? Shouldn't there a rollback feature? Shouldn't joomla extension installation prevent installation wrong/incompatible extensions? Though it's a third party issue - this is a non expected behaviour breaking the backend. Should be considered as feature request rather than closing the ticket.

  • Prevent site breaks by detecting incompatible extensions
  • Rollback feature if installation goes wrong
avatar GixxerMKD
GixxerMKD - comment - 25 Sep 2020

Exactly what i thought.

+1

On Fri, 25 Sep 2020, 14:03 github-canni, notifications@github.com wrote:

@SharkyKZ https://github.com/SharkyKZ So installing an extension by a
user could possibly corrupt the whole installation? Shouldn't there a
rollback feature? Shouldn't joomla extension installation prevent
installation wrong/incompatible extensions? Though it's a third party issue

  • this is a non expected behaviour breaking the backend. Should be
    considered as feature request rather than closing the ticket.

    • Prevent site breaks by detecting incompatible extensions
    • Rollback feature if installation goes wrong


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#29394 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJWCTYYVI3ZVJOWDDEPYBPLSHSBJHANCNFSM4NRBS6PA
.

avatar SharkyKZ
SharkyKZ - comment - 25 Sep 2020

This is something for extension developers to implement. We cannot possibly tell whether an extension is compatible or not. This should be done in extension's installation script.

avatar GixxerMKD
GixxerMKD - comment - 25 Sep 2020

Yes but we are talking about user making mistake and selecting wrong file
for installation which would render his site completely useless.

On Fri, 25 Sep 2020, 14:21 SharkyKZ, notifications@github.com wrote:

This is something for extension developers to implement. We cannot
possibly tell whether an extension is compatible or not. This should be
done in extension's installation script.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#29394 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJWCTY4B5CDWNOQLBOB7XB3SHSDMJANCNFSM4NRBS6PA
.

avatar ReLater
ReLater - comment - 25 Sep 2020

How should Joomla identify if an extension is not compatible with it? Impossible. And if an extension breaks Joomla completely how can a rollback feature help that is also broken then.

The only reliable "rollback" is a backup before installation. Akeeba Backup for Joomla 4 is out for a while now. Therefore no problem to make backups.

This is something for extension developers to implement.

Exactly! The extension must block the installation, not Joomla.

Add a Comment

Login with GitHub to post a comment