? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
1 Jun 2020

Pull Request for Issue #29318 .

Summary of Changes

Attempts to fix the spacing around the buttons on the dashboard modal

Testing Instructions

Before patch:
image

After patch: No spacing under the red box to the bottom border

Documentation Changes Required

None

avatar wilsonge wilsonge - open - 1 Jun 2020
avatar wilsonge wilsonge - change - 1 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jun 2020
Category Administration Templates (admin)
avatar wilsonge wilsonge - change - 1 Jun 2020
Title
Fix the extra padding under the modal buttons
[4.0] Fix the extra padding under the modal buttons
avatar wilsonge wilsonge - edited - 1 Jun 2020
avatar wilsonge wilsonge - change - 1 Jun 2020
The description was changed
avatar wilsonge wilsonge - edited - 1 Jun 2020
avatar bonzani bonzani - test_item - 2 Jun 2020 - Tested successfully
avatar bonzani
bonzani - comment - 2 Jun 2020

I have tested this item successfully on dbc781a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29375.

avatar richard67
richard67 - comment - 2 Jun 2020

@wilsonge Do I get the issue right that it happens only on certain browsers and OS (Mac)?

At least I can't reproduce here with Firefox for Windows.

avatar SharkyKZ
SharkyKZ - comment - 2 Jun 2020

@richard67 Yes, issue may or may not occur based on your OS/browser.

avatar SharkyKZ SharkyKZ - test_item - 2 Jun 2020 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 2 Jun 2020

I have tested this item successfully on dbc781a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29375.

avatar SharkyKZ SharkyKZ - change - 2 Jun 2020
Status Pending Ready to Commit
Labels Added: ?
avatar SharkyKZ
SharkyKZ - comment - 2 Jun 2020

RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29375.

avatar richard67 richard67 - change - 2 Jun 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-06-02 07:49:14
Closed_By richard67
Labels Added: ?
avatar richard67 richard67 - close - 2 Jun 2020
avatar richard67 richard67 - merge - 2 Jun 2020
avatar richard67
richard67 - comment - 2 Jun 2020

Thanks!

avatar Quy
Quy - comment - 2 Jun 2020

This is not the correct fix.

Before PR:
29375-before

After PR:
29375-after

avatar richard67
richard67 - comment - 2 Jun 2020

Seems I haven’t seen that when testing it myself before merging.

@Quy Could you open an issue? Or is there already one?

Add a Comment

Login with GitHub to post a comment