Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#29368] - [4.0] Add markup to move buttons to next line

? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
1 Jun 2020

Summary of Changes

Add markup to move buttons to next line.

Testing Instructions

Go to Global Configuration > Installer
Change Updates Caching (in hours) to 0.
Go to Post Installation Messages.
See other messages where buttons are below messages.

update-notification

avatar Quy Quy - open - 1 Jun 2020
avatar Quy Quy - change - 1 Jun 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jun 2020
Category ⇒ Administration Language & Strings
avatar jwaisner jwaisner - test_item - 1 Jun 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 1 Jun 2020

I have tested this item ✅ successfully on 6f9debe

Work as expected.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29368.

avatar C-Lodder
C-Lodder - comment - 1 Jun 2020

You should really avoid adding HTML to the language files

avatar Quy
Quy - comment - 1 Jun 2020

Yes, however, other strings already have markup. For example:

joomla-cms/administrator/language/en-GB/com_cpanel.ini

Line 23 in 5e137db

COM_CPANEL_MSG_ADDNOSNIFF_BODY="<p>Joomla is now shipped with additional security hardenings in the default htaccess.txt and web.config.txt files. These hardenings disable the so called MIME-type sniffing feature in web browsers. The sniffing leads to specific attack vectors, where scripts in normally harmless file formats (eg images) will be executed, leading to Cross-Site-Scripting vulnerabilities.</p><p>The security team recommends to manually apply the necessary changes to existing .htaccess or web.config files, as those files can not be updated automatically.</p><p><strong>Changes for .htaccess</strong><br />Add the following lines before \"## Mod_rewrite in use.\":</p><pre>&lt;IfModule mod_headers.c&gt;\nHeader always set X-Content-Type-Options \"nosniff\"\n&lt;/IfModule&gt;</pre><p><strong>Changes for web.config</strong><br />Add the following lines right after \"&lt;/rewrite&gt;\":</p><pre>&lt;httpProtocol&gt;\n &lt;customHeaders&gt;\n &lt;add name=\"X-Content-Type-Options\" value=\"nosniff\" /&gt;\n &lt;/customHeaders&gt;\n&lt;/httpProtocol&gt;</pre>"

avatar Quy
Quy - comment - 1 Jun 2020

How to do the following without markup?

stats

avatar wilsonge wilsonge - change - 1 Jun 2020
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-06-01 23:30:31
Closed_By ⇒ wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 1 Jun 2020
avatar wilsonge wilsonge - merge - 1 Jun 2020
avatar wilsonge
wilsonge - comment - 1 Jun 2020

Given it makes things consistent good enough for me

Add a Comment

Login with GitHub to post a comment