Feeling Lucky
?
?
[#29359] - [4.0] [com_templates] Move form manipulation to model
- Fixed in Code Base
- 1 Jun 2020
- Medium
- Build: 4.0-dev
- # 29359
- Diff
- SharkyKZ:j4/cleanup/style-form
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Moves some form code from the view to the model. Forms should never be manipulated in the view - the changes are never reflected when validating the form.
Testing Instructions
Edit a site template style.
Check that Default field appears as a switcher on monolingual sites and as a dropdown on multilingual sites.
Check that you can still save the style.
Expected result
Works like before.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates |
Quy
- comment
- 1 Jun 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29359.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 1 Jun 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29359.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-01 22:43:46 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
wilsonge
- comment
- 1 Jun 2020
Thanks for the cleanup. Nice spot!
I have tested this item✅ successfully on a23a183
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29359.