[#29353] - fixes issue with type transformations
- Fixed in Code Base
- 14 Nov 2020
- Medium
- Build: staging
- # 29353
- Diff
- jigius:staging
- Success Hound Smells good to me. Woof! Details
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr Build is passing Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Since PHP 7.{1-4} server's logs are polluted with notice messages PHP Notice: A non well formed numeric value encountered in %ROOT%/libraries/src/Profiler/Profiler.php on line 126.
The problem is wrong type casting (from string to float).
This patch is resolving this.
Testing Instructions
Looking for mentioned notices into server's logs after any pages have being requested via http proto.
Attention: notice level of messages has to been allowed!
Expected result
Mentioned notices is not found.
Actual result
Mentioned notices is found.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I moved this to the next version and have an annotation.
With the new code we loose "+" sign for time and memory on output. I would suggest to precompile this values before adding this to the object and in the printf function.
Or evaluate why and if we need this * / 1000 manipulation.
I would suggest to precompile this values before adding this to the object and in the printf function.
Are you suggesting to change values stored in Joomla\Profiler\Profiler::$marks? I'm hesitant to do this against staging in case anyone actually uses these values as string. On the other hand, this could avoid some problems in existing code when upgrading to PHP 8 (e.g. like we currently have in Debug plugin). In any case we should totally do this at least in 4.0.
I can make the PR, just need to know for which branch.
Anyways, this PR is fine for now.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29353.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29353.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-14 15:05:39 |
| Closed_By | ⇒ | HLeithner |
Thanks
I have tested this item✅ successfully on 4f1d9f5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29353.