Information Required ?
avatar PhilETaylor
PhilETaylor
31 May 2020

Steps to reproduce the issue

Edit a user in Joomla 4.0.0 beta 1 admin console

Go to the User Action Log Options

Expected result

Email Notifications field label with no asterisk indicating its a required field because how can a toggle yes/no be a required field?

Actual result

Email notifications *

Screenshot 2020-05-31 at 19 13 25

avatar PhilETaylor PhilETaylor - open - 31 May 2020
avatar joomla-cms-bot joomla-cms-bot - change - 31 May 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 31 May 2020
avatar brianteeman
brianteeman - comment - 31 May 2020

I agree. I brought this up before and was told I was wrong

avatar brianteeman
brianteeman - comment - 31 May 2020

See #24982

avatar conconnl
conconnl - comment - 31 May 2020

Totally agree, if you can choose 2 options (Yes/No) then it's not required as you do not have the option to not choose anything.

Asterisk should be removed.

avatar mbabker
mbabker - comment - 1 Jun 2020

Totally agree, if you can choose 2 options (Yes/No) then it's not required as you do not have the option to not choose anything.

#24982 (comment) and follow on comments still stand. Just because you don't have a way of submitting a non-empty value through the UI does not mean that the form field definition should not have a required attribute if the application data model states that the field cannot be stored with a non-empty value, especially now that Joomla claims to have an API (and this API for some strange reason elects to use form definitions in a number of locations). Sadly, the only way to enforce the "this field cannot be stored with an empty value" server-side validation rule because Joomla does not have a proper validator API (a proper validator API is something like those in Symfony or Laravel where data models can be validated at will regardless of input source, not the Joomla\CMS\Form\FormRule class) is with the use of the required attribute, which bleeds into the frontend display. But hey, too late to do anything for 4.0 on that topic now.

avatar brianteeman
brianteeman - comment - 14 Nov 2020

This should be closed for the reasons stated above

avatar Quy Quy - change - 15 Nov 2020
Labels Added: Information Required
avatar Quy Quy - labeled - 15 Nov 2020
avatar brianteeman
brianteeman - comment - 8 Apr 2021

@Quy What extra information are you asking for /me confused

avatar Quy
Quy - comment - 8 Apr 2021

Sorry I don't remember. Close?

avatar PhilETaylor PhilETaylor - change - 8 Apr 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-04-08 21:31:04
Closed_By PhilETaylor
avatar PhilETaylor PhilETaylor - close - 8 Apr 2021

Add a Comment

Login with GitHub to post a comment