? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
31 May 2020

The fields in the edit profile are hardcoded to display (optional)

This is unlike any other form where only required fields are marked with *

This PR removes the hard coded optional without replacement. Both for consistency and removal of clutter AND by hardcoding it this way it is applied to readonly fields etc that are neither required or optional

To test apply the PR and on the front end check the edit user profile form

avatar brianteeman brianteeman - open - 31 May 2020
avatar brianteeman brianteeman - change - 31 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 May 2020
Category Front End com_users Language & Strings
avatar brianteeman brianteeman - change - 31 May 2020
Labels Added: ? ?
avatar bonzani bonzani - test_item - 1 Jun 2020 - Tested successfully
avatar bonzani
bonzani - comment - 1 Jun 2020

I have tested this item successfully on 6a061aa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29339.

avatar toivo toivo - test_item - 1 Jun 2020 - Tested successfully
avatar toivo
toivo - comment - 1 Jun 2020

I have tested this item successfully on 6a061aa

Tested successfully in 4.0.0-beta2-dev.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29339.

avatar richard67 richard67 - change - 1 Jun 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 1 Jun 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29339.

avatar richard67
richard67 - comment - 1 Jun 2020

The js error "TypeError: b.addEventListener is not a function" shown for management.min.js in the browser console when loading the profile edit page on frontend is not related to this PR, it happens also without it.

@brianteeman Do you know if we have already an issue for it?

avatar wilsonge wilsonge - change - 1 Jun 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-06-01 13:21:30
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 1 Jun 2020
avatar wilsonge wilsonge - merge - 1 Jun 2020
avatar wilsonge
wilsonge - comment - 1 Jun 2020

Thanks!

avatar brianteeman
brianteeman - comment - 1 Jun 2020

thanks

Add a Comment

Login with GitHub to post a comment