? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
31 May 2020

Removes the toolbar markup as it is not needed - they are just buttons.
Bonus this also ensures the buttons are spaced correctly

To test. Install sample data and log in to the front end
Test the menu items for Site Settings and Template Settings and also test editing a module

Before this PR the buttons are next to each other without any spacing

After this PR the toolbar markup is removed and the buttons are spaced correctly

avatar brianteeman brianteeman - open - 31 May 2020
avatar brianteeman brianteeman - change - 31 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 May 2020
Category Front End com_config
avatar Quy Quy - test_item - 31 May 2020 - Tested successfully
avatar Quy
Quy - comment - 31 May 2020

I have tested this item successfully on ba4f0d3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29320.

avatar ChristineWk ChristineWk - test_item - 31 May 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 31 May 2020

I have tested this item successfully on ba4f0d3

about spaces (editing a module) we had here: https://issues.joomla.org/tracker/joomla-cms/29143


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29320.

avatar Quy Quy - change - 31 May 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 31 May 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29320.

avatar richard67 richard67 - change - 31 May 2020
Labels Added: ? ?
avatar richard67 richard67 - change - 31 May 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-31 19:19:42
Closed_By richard67
Labels
avatar richard67 richard67 - close - 31 May 2020
avatar richard67 richard67 - merge - 31 May 2020
avatar richard67
richard67 - comment - 31 May 2020

Thanks!

Add a Comment

Login with GitHub to post a comment