[#29305] - [4.0] Fix bootstrap tabs active background
- Fixed in Code Base
- 10 Jun 2020
- Medium
- Build: 4.0-dev
- # 29305
- Diff
- infograf768:4.0_bootstrap_tabs
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
In some cases, (and specially for 3rd party components and B/C), we need to use bootstrap tabs and not uitab or joomlatab.
The advantage of bootstrap tab is that we have accordion and slide variations.
In that case, when the tab is active, the background color is not differentiated from the the non-active tab.
Testing Instructions
Choose any edit for example com_content/tmpl/article/edit.php
Replace uitab in
uitab.startTabSet
uitab.addTab
uitab.enTab
uitab.endTabSet
by bootstrap
example bootstrap.startTabSet
Before patch
Example here for a third party component.
After patch
Note
I did not find any other use of .nav-tabs .nav-item.show .nav-link, .nav-tabs .nav-link.active in core.
I tested with various atum main color without issue, but not tested all.
@coolcat-creations
Could you please check there are no undesired consequences?
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
joomla-tab does support that. iirc they are called orientation=vertical and view=accordion
Not the same way for accordion and no slide.
For accordion, I have already explained there is what I consider as a bug: one has to click on another tab to close the opened one, which is not the case for bootstrap:
look at sidebyside in com_associations.
With bootstrap, none of these limitations. The code is there and we can use it. There is no reason not to fix the background issue.
There are btw quite a few places where bootstrap accordion and slide are used in core: menutypes, finder, modules. They do not use Tabset thus why they don't need this patch.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29305.
I can't reproduce the issue. Looks like this without patch:
Reproducible with the TinyMCE plugin.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29305.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29305.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-10 22:35:01 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
Thanks!
| Category | Administration Templates (admin) | ⇒ | Administration Templates (admin) NPM Change |
joomla-tab does support that. iirc they are called orientation=vertical and view=accordion