? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
31 May 2020

Summary of Changes

In some cases, (and specially for 3rd party components and B/C), we need to use bootstrap tabs and not uitab or joomlatab.
The advantage of bootstrap tab is that we have accordion and slide variations.

In that case, when the tab is active, the background color is not differentiated from the the non-active tab.

Testing Instructions

Choose any edit for example com_content/tmpl/article/edit.php

Replace uitab in

uitab.startTabSet
uitab.addTab
uitab.enTab
uitab.endTabSet

by bootstrap
example bootstrap.startTabSet

Before patch

Example here for a third party component.

Screen Shot 2020-05-31 at 10 26 54

After patch

Screen Shot 2020-05-31 at 09 52 33

Note

I did not find any other use of .nav-tabs .nav-item.show .nav-link, .nav-tabs .nav-link.active in core.
I tested with various atum main color without issue, but not tested all.

@coolcat-creations
Could you please check there are no undesired consequences?

avatar infograf768 infograf768 - open - 31 May 2020
avatar infograf768 infograf768 - change - 31 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 May 2020
Category Administration Templates (admin)
avatar brianteeman
brianteeman - comment - 31 May 2020

The advantage of bootstrap tab is that we have accordion and slide variations.

joomla-tab does support that. iirc they are called orientation=vertical and view=accordion

avatar infograf768
infograf768 - comment - 31 May 2020

joomla-tab does support that. iirc they are called orientation=vertical and view=accordion

Not the same way for accordion and no slide.
For accordion, I have already explained there is what I consider as a bug: one has to click on another tab to close the opened one, which is not the case for bootstrap:
look at sidebyside in com_associations.

With bootstrap, none of these limitations. The code is there and we can use it. There is no reason not to fix the background issue.

avatar infograf768
infograf768 - comment - 31 May 2020

There are btw quite a few places where bootstrap accordion and slide are used in core: menutypes, finder, modules. They do not use Tabset thus why they don't need this patch.

avatar bonzani bonzani - test_item - 1 Jun 2020 - Tested successfully
avatar bonzani
bonzani - comment - 1 Jun 2020

I have tested this item successfully on b682b12


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29305.

avatar SharkyKZ
SharkyKZ - comment - 4 Jun 2020

I can't reproduce the issue. Looks like this without patch:

Screenshot_2020-06-04 Articles Edit - Joomla - Administration

avatar Quy
Quy - comment - 10 Jun 2020

Reproducible with the TinyMCE plugin.

29305

avatar Quy Quy - test_item - 10 Jun 2020 - Tested successfully
avatar Quy
Quy - comment - 10 Jun 2020

I have tested this item successfully on b682b12


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29305.

avatar Quy Quy - change - 10 Jun 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 10 Jun 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29305.

avatar wilsonge wilsonge - change - 10 Jun 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-06-10 22:35:01
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 10 Jun 2020
avatar wilsonge wilsonge - merge - 10 Jun 2020
avatar wilsonge
wilsonge - comment - 10 Jun 2020

Thanks!

avatar joomla-cms-bot joomla-cms-bot - change - 10 Jun 2020
Category Administration Templates (admin) Administration Templates (admin) NPM Change

Add a Comment

Login with GitHub to post a comment