? ?
avatar PhilETaylor
PhilETaylor
30 May 2020

Steps to reproduce the issue

Install Joomla 4.0.0 Beta 1
Edit your new admin user in admin
Click around the tabs

Expected result

The toggles to be 50/50

Actual result

SOME toggles are 50/50 and some are 100/0 then clicked become 0/100

Easier to explain with a video.

Screen Recording 2020-05-30 at 10 09 PM

System information (as much as possible)

Safari on Mac.

avatar PhilETaylor PhilETaylor - open - 30 May 2020
avatar joomla-cms-bot joomla-cms-bot - change - 30 May 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 30 May 2020
avatar infograf768 infograf768 - change - 31 May 2020
Labels Added: ?
avatar infograf768 infograf768 - labeled - 31 May 2020
avatar infograf768
infograf768 - comment - 31 May 2020

Confirmed. Specific to Safari.

avatar HLeithner HLeithner - change - 1 Jun 2020
Labels Added: ?
avatar HLeithner HLeithner - labeled - 1 Jun 2020
avatar jwaisner jwaisner - change - 1 Jun 2020
Status New Confirmed
Build staging 4.0-b1
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jun 2020
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - unlabeled - 1 Jun 2020
avatar wilsonge
wilsonge - comment - 1 Jun 2020

Adding z-index: 1000 to this SCSS block https://github.com/joomla/joomla-cms/blob/4.0.0-beta/build/media_source/system/scss/fields/switcher.scss#L90 seems to "solve" the problem. But given no SCSS in our entire tree has z-index values of 999 I kinda don't believe it's a real solution and it's some sort of mask. Also given bootstrap's dropdowns start with a z-index of 1000 we might set ourselves up for failure on pages with a switcher element and dropdown in close proximity.

avatar wilsonge
wilsonge - comment - 1 Jun 2020

Maybe @ciar4n is this one you are able to help with? Dunno if you actually have a safari install available to you

avatar PhilETaylor
PhilETaylor - comment - 1 Jun 2020

But why do some look and work ok and not others on the same tab/page? Surely that’s the key?

This happens all throughout the admin console in safari - not just this example page - some work some don’t

Sent from my iPhone

On 2 Jun 2020, at 00:08, George Wilson notifications@github.com wrote:


Adding z-index: 1000 to this SCSS block https://github.com/joomla/joomla-cms/blob/4.0.0-beta/build/media_source/system/scss/fields/switcher.scss#L90 seems to "solve" the problem. But given no SCSS in our entire tree has z-index values of 999 I kinda don't believe it's a real solution and it's some sort of mask. Also given bootstrap's dropdowns start with a z-index of 1000 we might set ourselves up for failure on pages with a switcher element and dropdown in close proximity.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

avatar PhilETaylor
PhilETaylor - comment - 1 Jun 2020

Also as you can see hover and toggling can make visual changes of OTHER toggles on the same page - surely they should be totally independent?

Sent from my iPhone

On 2 Jun 2020, at 00:14, George Wilson notifications@github.com wrote:


Maybe @ciar4n is this one you are able to help with? Dunno if you actually have a safari install available to you


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

avatar wilsonge
wilsonge - comment - 1 Jun 2020

As far as I can tell it's any switcher element that's not in the first column of flex columns. They definitely should be independent. The switchers are entirely CSS driven though (there's no JS) - so it has to be some sort of browser bug (which is also why things work in firefox and chrome)

avatar infograf768 infograf768 - change - 2 Jun 2020
Title
[4.0b1] Toggles Inconsistancy
[4.0b1] Toggles Inconsistancy (Safari)
avatar infograf768 infograf768 - edited - 2 Jun 2020
avatar infograf768
infograf768 - comment - 2 Jun 2020

I still think this is a release blocker. No idea why this was modified.

avatar ciar4n
ciar4n - comment - 2 Jun 2020

Maybe @ciar4n is this one you are able to help with? Dunno if you actually have a safari install available to you

I'm running Windows so sorry to say I dont have Safari available to me.

Going by the screenshot, the issue only appears to happen to items in the second column? If so this may imply that...

break-inside: avoid;
page-break-inside: avoid;

... is not been applied in Safari. To confirm does removing the column-count-md-2 column-count-lg-3 classes from the container of these fields resolve the issue?

avatar wilsonge wilsonge - change - 17 Jun 2020
Labels Added: ?
avatar wilsonge wilsonge - labeled - 17 Jun 2020
avatar infograf768
infograf768 - comment - 19 Aug 2020

The problem is overflow: hidden; for .switcher .toggle-outside

avatar ciar4n
ciar4n - comment - 19 Aug 2020

Sorry, I can't help you so. This issue been caused by overflow: hidden; makes no sense to me and I don't have a mac to test.

avatar infograf768
infograf768 - comment - 19 Aug 2020

it's a known problem in Safari with overflow hidden
https://devdojo.com/tnylea/safari-overflow-hidden-problem

Alas here we can't use the trick as position is absolute

avatar infograf768
infograf768 - comment - 19 Aug 2020

Looks like I found the solution

  overflow: hidden;
  -webkit-mask-image: -webkit-radial-gradient(white, black); // adding this
avatar infograf768
infograf768 - comment - 19 Aug 2020

Making PR now

avatar infograf768 infograf768 - close - 19 Aug 2020
avatar infograf768
infograf768 - comment - 19 Aug 2020

Clsing as we have a patch. Please test #30420

avatar infograf768 infograf768 - change - 19 Aug 2020
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2020-08-19 09:38:04
Closed_By infograf768
Labels Added: ?
Removed: ?
avatar infograf768 infograf768 - change - 19 Aug 2020
Labels Removed: ?
avatar infograf768 infograf768 - unlabeled - 19 Aug 2020
avatar Magnytu2
Magnytu2 - comment - 19 Aug 2020

I applied # 30420 but still get the same result.
Joomla__Patch_Tester_-J4_beta_4-_Administration

avatar infograf768
infograf768 - comment - 19 Aug 2020
  1. test results should be done in the pr
  2. patchtester is not enough. One needs to use npm to apply the modified scss to the css

Add a Comment

Login with GitHub to post a comment